Raise RuntimeError when gist is unavailable - #437 #438

Merged
merged 2 commits into from Mar 5, 2013

Conversation

Projects
None yet
3 participants

This commit raises RuntimeError if gist responds with a HTTP error preventing the error page from being included into generated text (#437).

Collaborator

parkr commented Dec 16, 2012

Instead of using Integer(data.code), use data.code.to_i. Otherwise, I like the handling of the error. I'm all about catching problems and not failing silently.

@imathis, what do you think?

Owner

imathis commented Dec 29, 2012

I dig it.

parkr added a commit that referenced this pull request Mar 5, 2013

Merge pull request #438 from roman-yepishev/gist_error
Raise RuntimeError when gist is unavailable - #437

@parkr parkr merged commit 51905b6 into imathis:master Mar 5, 2013

parkr added a commit that referenced this pull request Mar 5, 2013

Merge branch 'master' of github.com:imathis/octopress
* 'master' of github.com:imathis/octopress:
  Using data.code.to_i like a true Rubyist in plugins/gist_code.rb. Heh. #438
  Fix for bottom margin in nested lists.

paxswill added a commit to paxswill/StupidRobots that referenced this pull request Mar 29, 2013

Merge branch 'master' of git://github.com/imathis/octopress
* 'master' of git://github.com/imathis/octopress: (51 commits)
  fixed addSidebarToggler where index and section were flip-flopped
  Added sass-globbing, allowing plugin stylesheets to be auto-imported from the assets/stylesheets/plugins directory
  Improved: config_tag plugin is much more flexible now and can be used by other plugins directly through the config_tag method
  added config_tag plugin for integration of configuration into templates
  Fixed GitHub jsonp call. Closed #1118
  removed Twitter configuration for timeline and follow buton which are no longer integrated
  Mobile nav fixed.
  Removed Twitter and Ender.js. Added jQuery and updated Modernizr
  Added .gitattributes file to keep CRLF's out of the codebase.
  Using data.code.to_i like a true Rubyist in plugins/gist_code.rb. Heh. #438
  Using data.code.to_i like a true Rubyist in plugins/gist_code.rb. Heh. #438
  Bump sinatra to 1.3.5
  It's 2013. Hi, MIT License.
  Use HTML5 '&' character to connect query params in GitHub API call. #1031.
  Use the Github API repo sorting.
  Fixed issue with mobile nav choosing the last option by default. Fixes #950.
  fixed issue #949 using @alexkirmse's patch
  Update plugins/pygments_code.rb
  Async load of Facebook JS
  Update plugins/pygments_code.rb
  ...

Conflicts:
	Rakefile
	_config.yml

dharFr added a commit to dharFr/octopress that referenced this pull request May 11, 2013

Merge branch 'master' of git://github.com/imathis/octopress
* 'master' of git://github.com/imathis/octopress: (69 commits)
  Recent posts sidebar now correctly observes titlecase settings
  Footnotes styling updates
  Removed a couple of buggy filters on RDiscount (for now)
  Updated RDiscount, added footnotes and other extensions
  Sinatra now correctly returns code 404 when a page is not found. Closes #1198
  Added support for deploying to github.io
  Accepting all non-whitespace characters as language names for Pygments code highlighting
  Allowing dashes in code names. Closes #1166
  fixed video wrapping js
  fixed mobile navigation
  fixed addSidebarToggler where index and section were flip-flopped
  Added sass-globbing, allowing plugin stylesheets to be auto-imported from the assets/stylesheets/plugins directory
  Improved: config_tag plugin is much more flexible now and can be used by other plugins directly through the config_tag method
  added config_tag plugin for integration of configuration into templates
  Fixed GitHub jsonp call. Closed #1118
  removed Twitter configuration for timeline and follow buton which are no longer integrated
  Mobile nav fixed.
  Removed Twitter and Ender.js. Added jQuery and updated Modernizr
  Added .gitattributes file to keep CRLF's out of the codebase.
  Using data.code.to_i like a true Rubyist in plugins/gist_code.rb. Heh. #438
  ...

MarkyV added a commit to MarkyV/octopress that referenced this pull request Aug 8, 2013

briansimmons pushed a commit to briansimmons/octopress that referenced this pull request Aug 20, 2013

Merge pull request #438 from roman-yepishev/gist_error
Raise RuntimeError when gist is unavailable - #437

briansimmons pushed a commit to briansimmons/octopress that referenced this pull request Aug 20, 2013

briansimmons pushed a commit to briansimmons/octopress that referenced this pull request Aug 20, 2013

briansimmons pushed a commit to briansimmons/octopress that referenced this pull request Aug 20, 2013

Merge branch 'master' of github.com:imathis/octopress
* 'master' of github.com:imathis/octopress:
  Using data.code.to_i like a true Rubyist in plugins/gist_code.rb. Heh. #438
  Fix for bottom margin in nested lists.

jhwist added a commit to jhwist/octopress that referenced this pull request Jan 14, 2014

lehrblogger pushed a commit to lehrblogger/lehrblogger.com-old that referenced this pull request Feb 24, 2014

Merge pull request #438 from roman-yepishev/gist_error
Raise RuntimeError when gist is unavailable - #437

lehrblogger pushed a commit to lehrblogger/lehrblogger.com-old that referenced this pull request Feb 24, 2014

lehrblogger pushed a commit to lehrblogger/lehrblogger.com-old that referenced this pull request Feb 24, 2014

lehrblogger pushed a commit to lehrblogger/lehrblogger.com-old that referenced this pull request Feb 24, 2014

Merge branch 'master' of github.com:imathis/octopress
* 'master' of github.com:imathis/octopress:
  Using data.code.to_i like a true Rubyist in plugins/gist_code.rb. Heh. #438
  Fix for bottom margin in nested lists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment