Skip to content

A tiny extra piece of configurability will make Octopress preview work on ...#780

Closed
maxlinc wants to merge 1 commit into
imathis:masterfrom
maxlinc:octo_to_cloud9
Closed

A tiny extra piece of configurability will make Octopress preview work on ...#780
maxlinc wants to merge 1 commit into
imathis:masterfrom
maxlinc:octo_to_cloud9

Conversation

@maxlinc

@maxlinc maxlinc commented Oct 4, 2012

Copy link
Copy Markdown

...c9.io out of the box.

@janjongboom

Copy link
Copy Markdown

+1 for this pull request. The environment variables are used on more envs than just Cloud9.

@systole

systole commented Nov 14, 2012

Copy link
Copy Markdown

+1 for C9.io

@ralgh

ralgh commented Nov 28, 2012

Copy link
Copy Markdown

+1, Works great

@parkr

parkr commented Dec 17, 2012

Copy link
Copy Markdown
Collaborator

Hm, let me just make sure this doesn't break rake preview.

@parkr

parkr commented Dec 17, 2012

Copy link
Copy Markdown
Collaborator

Works for me. I'll merge the changes into 2.1.

@parkr

parkr commented Dec 17, 2012

Copy link
Copy Markdown
Collaborator

Merged in 329d2c5.

@parkr parkr closed this Dec 17, 2012
@parkr

parkr commented Dec 17, 2012

Copy link
Copy Markdown
Collaborator

Thinking about this more, this can really f up some things on production servers. Going to still use ENV vars, but favour OCTOPRESS_-prefixed ones.

parkr added a commit that referenced this pull request Dec 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants