Added the ability to have certain query string parameters excluded from the cache key #113

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@lazytom
Contributor
lazytom commented Nov 11, 2014

sometimes one might want to exclude certain query string parameters from
the cache key, e.g. when using a qs parameter as a cache buster for a
CDN, etc.

added the ability to do this via a config item:

<ignoredquerystringparameters parameternames="" />

the parameternames attribute accepts a comma-delimited list of parameter
names that will be ignored by internal processing (and thus also from
the cache key)

lazytom added some commits Nov 11, 2014
@lazytom lazytom Fix Nuget package restore for DiagnosticJson project 390257b
@lazytom lazytom add the ability to have certain query string parameters excluded from…
… the cache key, etc.

sometimes one might want to exclude certain query string parameters from
the cache key, e.g. when using a qs parameter as a cache buster for a
CDN, etc.

added the ability to do this via a config item:

<ignoredquerystringparameters parameternames="" />

the parameternames attribute accepts a comma-delimited list of parameter
names that will be ignored by internal processing (and thus also from
the cache key)
9b53039
@nathanaeljones
Member

Thanks for the pull request!

Currently all new development is happening on the develop branch. I can merge an updated pull request that:

  1. Exposes the configuration via IPipelineConfig and PipelineConfig: https://github.com/imazen/resizer/blob/master/Core/Configuration/PipelineConfig.c (caching is suggested, as this executes for every HTTP request going through the server).

  2. Targets the 'develop' branch - which should also have correct NuGet handling.

  3. Uses the existing "pipeline" XML element - "pipeline.dropQuerystringKeys" would probably be best.

  4. Applies to both InterceptModule and AsyncInterceptModule

@lazytom lazytom closed this Nov 11, 2014
@nathanaeljones nathanaeljones added a commit that referenced this pull request May 12, 2015
@nathanaeljones nathanaeljones Major core changes: Assign StaticFileHandler for all VPP-only request…
…s (Fixes #140). Apply .Rewrite changes to all (existing) image requests (fixes fake extension issue #8 and #113). Call ImageMissing for *all* image 404, not just those processed.
1e397ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment