Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to have certain query string parameters excluded from the cache key #113

Closed
wants to merge 2 commits into from

Conversation

@lazytom
Copy link
Contributor

@lazytom lazytom commented Nov 11, 2014

sometimes one might want to exclude certain query string parameters from
the cache key, e.g. when using a qs parameter as a cache buster for a
CDN, etc.

added the ability to do this via a config item:

<ignoredquerystringparameters parameternames="" />

the parameternames attribute accepts a comma-delimited list of parameter
names that will be ignored by internal processing (and thus also from
the cache key)

lazytom added 2 commits Nov 11, 2014
… the cache key, etc.

sometimes one might want to exclude certain query string parameters from
the cache key, e.g. when using a qs parameter as a cache buster for a
CDN, etc.

added the ability to do this via a config item:

<ignoredquerystringparameters parameternames="" />

the parameternames attribute accepts a comma-delimited list of parameter
names that will be ignored by internal processing (and thus also from
the cache key)
@lilith
Copy link
Member

@lilith lilith commented Nov 11, 2014

Thanks for the pull request!

Currently all new development is happening on the develop branch. I can merge an updated pull request that:

  1. Exposes the configuration via IPipelineConfig and PipelineConfig: https://github.com/imazen/resizer/blob/master/Core/Configuration/PipelineConfig.c (caching is suggested, as this executes for every HTTP request going through the server).

  2. Targets the 'develop' branch - which should also have correct NuGet handling.

  3. Uses the existing "pipeline" XML element - "pipeline.dropQuerystringKeys" would probably be best.

  4. Applies to both InterceptModule and AsyncInterceptModule

@lazytom lazytom closed this Nov 11, 2014
lilith added a commit that referenced this pull request May 12, 2015
Fixes #140). Apply .Rewrite changes to all (existing) image requests (fixes fake extension issue #8 and #113). Call ImageMissing for *all* image 404, not just those processed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants