Permalink
Commits on Nov 7, 2017
  1. Add tests for the new watermark positions

    christeredvartsen committed Nov 7, 2017
    Also added more assertions for the existing watermark placements. Now
    testing above/below and next to all corners of the watermark image.
Commits on Oct 25, 2017
  1. Improve comment

    christeredvartsen committed Oct 25, 2017
Commits on Oct 18, 2017
  1. Fix exception expectation in PHPUnit

    christeredvartsen committed Oct 18, 2017
    This test has suddenly started to fail, most likely because of a bump in
    the PHPUnit version.
  2. Bump php requirement to 7.0

    christeredvartsen committed Oct 18, 2017
    Drop php-5.6 from the Travis-CI build matrix, and bump php requirement
    in composer.json from 5.6 to 7.0.
    
    Resolves #582.
Commits on Oct 9, 2017
  1. Change Icc transformation parameter name

    christeredvartsen committed Oct 9, 2017
    This commit changes the parameter name of the Icc image transformation
    from name to profile, and also adjusts some error messages and
    assertions in some test cases.
    
    Resolves #575.
Commits on Oct 3, 2017
  1. Remove empty line

    christeredvartsen committed Oct 3, 2017
Commits on Sep 29, 2017
  1. Move loaders / output converters to default config

    christeredvartsen committed Sep 17, 2017
    Instead of having the basic input loader and the basic output converter
    registered in the input loader manager the output converter manager by
    hard coding it in the application class we want it in the default
    configuration instead. The values in the list will need keys for
    identification for merging of custom configuration to work as expected.
  2. Add unit tests for the input loader manager

    christeredvartsen committed Sep 17, 2017
    Add some missing unit tests for the input loader manager, and also add
    return statements that returns itself to be able to chain some of the
    methods.
  3. Fix minor coding-style issues

    christeredvartsen committed Sep 13, 2017
    Also added some missing comments here and there.
Commits on Jul 28, 2017
  1. Test multiple database / storage adapters using Behat (#550)

    christeredvartsen committed Jul 28, 2017
    * Enable autoloading of Behat context classes
    
    Instead of adding the path of the Behat feature context classes to the
    Behat configuration file, and manually including the files in the
    bootstrap for the unit tests the directory is added to autoload-dev in
    composer.json
    
    * Add interface for Behat feature context classes
    
    The interface must be implemented by all feature context classes so they
    can provide an instance of a database and storage adapter to be used in
    the different suites for Behat.
    
    * Use PSR-4 instead of PSR-0 for context classes
    
    To make the name of the Behat context feature classes more clear, we
    should use PSR-4 instead of PSR-0. This allows for the usage of
    underscores in the classname without having the autoloader automatically
    assuming the _ in the classname matches a / in the path.
    
    Because of this we can now match:
    
    Database_Storage => %path%/Database_Storage.php
    
    and not
    
    Database_Storage => %path%/Database/Storage.php
    
    * Enable Behat testing of all adapters
    
    This commit introduces different suites in the Behat test suite, which
    enables testing of all the different database and storage adapters, and
    combinations of these.
    
    Currently only the MongoDB database adapter and the GridFS storage
    adapter is tested, which has been the case since Imbo first started
    using Behat for integration tests.
    
    Each suite, which is a combination of a database adapter and a storage
    adapter should be added to behat.yml.dist, and should follow the
    following naming convention:
    
    <database adapter>_<storage adapter>, for instance "mongodb_gridfs" and
    must refer to a context class which follows the same convention, only
    that the names should match the specific names of the adapters:
    
    mongodb_gridfs => MongoDB_GridFS which in turn refers to the following
    adapters:
    
    - Imbo\Database\MongoDB
    - Imbo\Storage\GridFS
    
    Each new context class must implement the ImboFeatureContext interface,
    which introduces the two methods that is required to return the database
    and storage adapters. Each feature context can also have one or more
    Behat hooks that can be used to setup / tear down the specific suites.
    Each suite is expected to clear up all resources it generates in the
    test run.
    
    Resolves #279
    
    * Add a namespace for Behat feature context classes
    
    This commits adds ImboBehatFeatureContext as a namespace to all classes
    related to the feature context classes used in Behat tests. Some classes
    have also been renamed to better suit their purpose.
    
    * Add traits for database and storage adapters
    
    To more easily test combinations of database and storage adapters in the
    Behat test suites we can use traits for the different adapters. Each
    adapter should be responsible of setup / teardown functionality related
    to the different adapters. Each suite could then simply use two traits
    in combination to test them.
    
    * Skip traits and use configuration for suites
    
    Instead of having traits for the different adapters we want to test, and
    a class for each combination this commit will use configuration from the
    suites in the behat.yml[.dist] file instead. We also need to exchange
    configuration between the context triggered by Behat (which runs ::setUp() /
    ::tearDown()), and the context from when Imbo gets a request from the test
    (::getAdapter). This is done with a request header. The main feature
    context has been renamed back to FeatureContext as we no longer need the
    previously added FeatureContext interface. The interface added two
    methods that is no longer needed.
    
    * Add suite for MongoDB and Filesystem adapters
    
    * Provide sane default values for the Images model
    
    This gives the Imbo\Model\Images model sane deafult values for hits,
    limit and page.
    
    Resolves #553
    
    * Add test-suite for Doctrine/SQLite and filesystem
    
    Adds a separate suite for testing the combination of the
    Imbo\Database\Doctrine database adapter (with a SQLite database) and the
    Imbo\Storage\Filesystem storage adapter.
    
    * Add database setup for Doctrine/SQLite test
    
    The doctrine_sqlite_filesystem suite uses a SQLite database for testing,
    and this class is responsible for setting up / clearing the database
    used for testing.
    
    * Adjust comparison to work for non-type databases
    
    As the Doctrine database does not handle types in the same way as MySQL
    / MongoDB we need to adjust the tests as the Behat API Extension is
    type-sensitive on comparisons such as theses.
    
    * Order by the update flag for correct results
    
    To get the lastest value from the updated column the adapter must add
    ordering.
    
    Resolves #556.
    
    * Add method for fetching users in the database
    
    This is a helper method for fetching the unique user names currently
    found in the database. If no users-filter is used with the global images
    endpoint we need to fetch the list of all users currently in the
    database to be sure that the public key has access to all of them.
    
    * Clean up tests for database adapters
    
    Some missing tests have been added, and a generic clean-up has been done
    as well, as will be done to all test cases. Add test for the newly added
    getAllUsers-method.
    
    * Fix getImages and getLastModified
    
    Implement the new behaviour for getImages, where images from all users
    will be returned if the users-parameter is empty. The
    getLastModified-methods are also updated and implements the behaviour as
    specified in the method documentation found in the interface.
    
    * Update docs to reflect new behaviour of /images
    
    * Remove is_array check
    
    The Request::getUsers() method always returns an array, so no need for
    the check.
    
    * Clean up test case annotations
    
    * Fetch all users for auth when query param is empty
    
    When the client does not specify the users-filter when requesting the
    global images endpoint Imbo should use all users found in the current
    database to use for authentication. Also added test case to verify new
    behaviour.
    
    * Rename test class
    
    * Use setup file for SQL
    
    Instead of duplicating the SQL for creating the tables in the database
    the test classes now use the contents of the file found in the setup dir,
    which is also included in the documentation.
    
    * Supply suite settings for the setUp method
    
    Some suites needs extra settings that can be used in the set up, so this
    commit adds a parameter to the setUp method that holds all settings for
    the  current suite.
    
    * Add suite for Doctrine (MySQL) and Filesystem
    
    This commit adds a Behat suite for testing the Doctrine adapter with a
    MySQL database in combination with the Filesystem storage adapter. For
    this to work we need to enable the mysql service in Travis-CI.
    
    * Update README to reflect new Behat suites
    
    * Fix issues raised in code review of #550
    
    As we can't define constants through the Behat configuration file I
    decided to simply add a config entry in each suite for the path to the
    project root. The suites don't inherit configuration from some default
    place, so the same key => value has to be defined in every suite. For
    PHPUnit a project root constant has been set in the bootstrap script.
Commits on May 28, 2017
  1. Remove the MD5 image identifier generator (#548)

    christeredvartsen committed May 28, 2017
    * Remove the MD5 image identifier generator. Resolves #546
Commits on May 4, 2017
  1. Add support for ± when comparing image size (#544)

    christeredvartsen committed May 4, 2017
    * Add support for ± when comparing image size in the Behat test suite. Resolves #543
Commits on Apr 28, 2017
  1. Remove support for pdo in Doctrine configuration and custom connectio…

    christeredvartsen committed Apr 28, 2017
    …n object (#541)
    
    * Remove support for pdo in Doctrine configuration, and removed support for the connection parameter to the Doctrine-based adapters. Resolves #535