Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Last modified timestamp not updated when updating metadata using the Doctrine adapter #530
I stumbled upon a discrepancy in the Doctrine database-adapter, namely that it the
This is, however, the case for the Mongo and MongoDB adapters.
As an example, look at the
If we compare this to the
In the IRC-channel, it was discussed changing the interface for the database-class to include a method to explicitly update the last-modified timestamp, and then have it be the responsibility of the resource-handlers to update the timestamp when necessary.
My proposal would be to bug-fix the Doctrine adapter for Imbo 2.x, and then modify the
If you agree, I'll create two PRs with the bug-fix + update.
referenced this issue
May 15, 2018
I finally got around to creating the "easy" fix for the 2.x-branch (see #597).
Is the preferred approach for 3.x still to create a new method on the
If so, I'll create a PR for that against the 3.x branch. What name should this new method have?
I'd prefer if we kept the notion of time in the method name, so that it's clear that we're updating the timestamp of when the image was updated - and not just saying that it has been updated. How about something like
PHP doesn't allow function calls as default parameters - so we'd have to do