New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add untranspiled build and typescript support #177
Conversation
465c141
to
9e87387
Compare
This pull request also changes the way prettier is applied to be in line with what is recommended. This means removing the plugin that runs prettier through eslint. Instead the config is used, meaning that formatting rules are disabled for eslint and left to prettier. The pre-commit hook was changed accordingly. I've also added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @brfrth, I liked these changes very much, mostly the prettier ones. I made just a comment that is very important about the generated files names.
@imbrn what's the current list of generated names for all builds? |
@brfrth These are the file names generated by the build:
the map files:
and in the Lines 5 to 8 in 8b2e7c7
|
@imbrn fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brfrth Please check the comments out.
a62105b
to
47f9ea3
Compare
I fixed the stuff you reviewed. I also went ahead and updated all the npm packages used, since quite a few of them were outdated. In the process I was able to reduce the usage of babel by quite a bit. If we ever want to target a specific browser list we need it again, but for now it seems the goal is just an ES5 transpile. Many projects (e.g. Vue) use I also updated the CircleCI config. |
I've pretty much copied Vue's approach, that should be the way to go. |
Added note about Typescript to the docs and changelog. |
IMHO; that's a 10-files project. Interested into this ? I can give it a shot maybe |
@cyrilchapon I already had a full rewrite done. A full migration won't happen just now as per @imbrn comment on the matter. That said: You are free to do a TypeScript rewrite and let us know. If we ever look to migrate we can merge your branch. |
I see. New transpilation stack will help anyways. I might give that a shot if I can take time to. |
Hey @brfrth , I'm sorry for being all this time off. Take a look at my last two comments. |
@imbrn Replied to both, resolved one. The other one you can decide on. |
@imbrn You want this squashed or merged as is? |
Yeah @barfurth , let's squash it before merging. |
Description
This pull request adds a single build that completely untranspiled called
v8n.esm.browser.js
. This build can be used for modern browsers where backward compatibility is no needed. It also adds typescript typings that allow usage of this package in a typescript environment.Fixes #165
Fixes #28
Fixes #180
Type of change
Checklist:
master
Unreleased
section of the CHANGELOG