Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to send any metrics #6

Open
kamaradclimber opened this issue Nov 13, 2014 · 1 comment
Open

Allow to send any metrics #6

kamaradclimber opened this issue Nov 13, 2014 · 1 comment

Comments

@kamaradclimber
Copy link

It would be nice to allow to send any metric present in some path of run_context.
Thus other cookbooks could add new metrics sent to graphite by this handler without rewriting it.

Additional metrics I can think of:

  • of ignored failures on resources

  • restart of an essential service (memcached, some database…)
  • time required to update a specific resource (execute[disk format] for instance)

The path could run_status['chef-handler-graphite'] which would contain a dictionary metric_name: value

Would you accept a PR for such a feature?

@imeyer
Copy link
Owner

imeyer commented Nov 25, 2014

@kamaradclimber Wow, yeah.. that would be quite amazing actually. Open a PR when you have something and we'll get it in there. 😄

kamaradclimber added a commit to kamaradclimber/chef-handler-graphite that referenced this issue Nov 26, 2014
Using run_context, users are able to add metrics sent via the
chef_handler.
It will help to count various event (ignored failures) or measure
specific resource execution (disk format).

Fix imeyer#6
kamaradclimber added a commit to kamaradclimber/chef-handler-graphite that referenced this issue Nov 26, 2014
Using run_context, users are able to add metrics sent via the
chef_handler.
It will help to count various event (ignored failures) or measure
specific resource execution (disk format).

Fix imeyer#6
kamaradclimber added a commit to kamaradclimber/chef-handler-graphite that referenced this issue Nov 26, 2014
Using run_context, users are able to add metrics sent via the
chef_handler.
It will help to count various event (ignored failures) or measure
specific resource execution (disk format).

Fix imeyer#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants