Change PR body when file size reduced by zero percent #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohanNagar
changed the title
Contributor
|
Wonder if it wouldn't be nicer to print 0.3% when the rounded value is zero and otherwise print a rounded percentage e.g 1%? |
dabutvin
approved these changes
Jul 31, 2018
| sb.AppendLine(); | ||
| sb.AppendLine($"Your image file size has been reduced by **{imageStats[0].Percent:N0}%** 🎉"); | ||
|
|
||
| if (Math.Round(imageStats[0].Percent) == 0) |
| } | ||
|
|
||
| [TestMethod] | ||
| public void GivenZeroPercentReductionCommitMessage_ShouldOmitPercentage() |
Contributor
|
@RohanNagar this looks great! @dlemstra I agree that we could add that kind of logic. Hadn't thought about it when I wrote up the issue. I'll file a new request to make the change. This PR gives us the hook we need to build on. We had some other issues logged a while back about converting from KB to MB in some cases too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #120.