Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure fit parameter will respect overriding value fixes #268 #311

Merged
merged 4 commits into from Mar 13, 2019

Conversation

sherwinski
Copy link
Contributor

@sherwinski sherwinski commented Mar 12, 2019

Description

Any attempt to override the fit parameter when using a Background component will have no effect. Example + steps to reproduce can be found in #268.
Big thanks to @verbeeksteven for catching this and getting the ball rolling with #270.

Bug Fix

  • All existing unit tests are still passing (if applicable)
  • Add new passing unit tests to cover the code introduced by your PR
  • Update the readme
  • Update or add any necessary API documentation
  • Add some steps so we can test your bug fix
  • The PR title is in the conventional commit format: e.g. fix(<area>): fixed bug #issue-number
  • Add your info to the contributors array in package.json!

Steps to Test

Can be found under test/integration/react-imgix.test.jsx

@sherwinski sherwinski requested a review from jayeb March 12, 2019 22:41
@verbeeksteven
Copy link

Looks good to me 👍

@sherwinski sherwinski merged commit 15b0073 into master Mar 13, 2019
@sherwinski sherwinski deleted the fit-param-override branch March 13, 2019 17:58
@sherwinski sherwinski mentioned this pull request Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants