Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image height to calculate watermark top offset #313

Merged
merged 1 commit into from Dec 27, 2019

Conversation

@realsim
Copy link
Contributor

realsim commented Dec 26, 2019

Shouldn't we use image height to properly calculate watermark top offset?

@DarthSim

This comment has been minimized.

Copy link
Collaborator

DarthSim commented Dec 27, 2019

Oops! Thanks for the fix!

@DarthSim DarthSim merged commit f83b73a into imgproxy:master Dec 27, 2019
11 checks passed
11 checks passed
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: go1.11_vips8.6 Your tests passed on CircleCI!
Details
ci/circleci: go1.11_vips8.7 Your tests passed on CircleCI!
Details
ci/circleci: go1.11_vips8.8 Your tests passed on CircleCI!
Details
ci/circleci: go1.12_vips8.6 Your tests passed on CircleCI!
Details
ci/circleci: go1.12_vips8.7 Your tests passed on CircleCI!
Details
ci/circleci: go1.12_vips8.8 Your tests passed on CircleCI!
Details
ci/circleci: go1.13_vips8.6 Your tests passed on CircleCI!
Details
ci/circleci: go1.13_vips8.7 Your tests passed on CircleCI!
Details
ci/circleci: go1.13_vips8.8 Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.