Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support & upgrade to winit 0.25 #485

Merged
merged 6 commits into from May 23, 2021
Merged

Conversation

@repi
Copy link
Contributor

@repi repi commented May 22, 2021

Adds a new winit-25 feature that works just like the previous winit-24.

Leaves default for now on winit-24 though as glutin is still using it and can't mix and use multiple winit versions within this repo

@thomcc
thomcc approved these changes May 22, 2021
Copy link
Member

@thomcc thomcc left a comment

Hm, I do wonder if it's worth keeping support for winit-24. I suspect the valuable ones are 19, and latest (and everything in between doesn't matter so much). Oh well, this is fine for now.

@thomcc
Copy link
Member

@thomcc thomcc commented May 22, 2021

(Ah, rather, it's fine pending green CI, ofc)

@repi
Copy link
Contributor Author

@repi repi commented May 22, 2021

Believe need to at least support the previous version (0.24) in this case to not force complex dependent upgrades. Even some examples in this repo used glutin which still uses winit 0.24

@repi
Copy link
Contributor Author

@repi repi commented May 22, 2021

Hmm ok that can't really be solved as the CI builds the entire workspace which forces cargo feature resolver to unify all the features and build the imgui-winit-support with multiple winit versions which it will fail on (one for the default and one for winit 0.24 for the tests).

Could change so just add support for 0.25 but keep the default here on 0.24 until glutin and the examples also can use 0.25, believe that is the only workable approach?

@thomcc
Copy link
Member

@thomcc thomcc commented May 22, 2021

Could change so just add support for 0.25 but keep the default here on 0.24 until glutin and the examples also can use 0.25, believe that is the only workable approach?

SGTM

@thomcc
Copy link
Member

@thomcc thomcc commented May 22, 2021

Please file an issue for updating default to winit-25 once glutin supports it.

Or I can remember to do so later today.

@thomcc
Copy link
Member

@thomcc thomcc commented May 23, 2021

Hm? I would have been fine merging 92bed93.

@thomcc
Copy link
Member

@thomcc thomcc commented May 23, 2021

Thanks. Sorry about the hassles here. I'll merge this in a bit and take care of filing the followup.

@thomcc
Copy link
Member

@thomcc thomcc commented May 23, 2021

Since this doesn't change the default feature I think I can cut this as a patch release (0.7.1) of imgui-winit-support too, which means I can probably get to it later today.

@thomcc thomcc merged commit 79f9345 into imgui-rs:master May 23, 2021
8 checks passed
8 checks passed
@github-actions
Run linter
Details
@github-actions
Check rustfmt
Details
@github-actions
Run tests (stable, ubuntu-latest)
Details
@github-actions
Run tests (stable, macos-latest)
Details
@github-actions
Run tests (stable, windows-latest)
Details
@github-actions
Run tests (beta, ubuntu-latest)
Details
@github-actions
Run tests (beta, macos-latest)
Details
@github-actions
Run tests (beta, windows-latest)
Details
@thomcc
Copy link
Member

@thomcc thomcc commented May 23, 2021

Actually, I just did it now https://crates.io/crates/imgui-winit-support/0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants