Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataController - improve isNewWorkitem #187

Closed
rsoika opened this issue Aug 15, 2016 · 0 comments
Closed

DataController - improve isNewWorkitem #187

rsoika opened this issue Aug 15, 2016 · 0 comments
Labels
bug enhancement
Milestone
3.9.0

Comments

@rsoika
Copy link
Member

rsoika commented Aug 15, 2016

isNewWorkitem can not be idicated by the $UniqueID, because this id is genrated by the kernel before a plugin is processed. In case of an exception the id exists, even if the workite was not saved.

To fix this we can compare the $modified and $created attributes. These attributes are managed by the EntityService
@rsoika rsoika added this to the 3.9.0 milestone Aug 15, 2016
rsoika added a commit that referenced this issue Aug 15, 2016
@rsoika
fixed isNewWorkitem - compare by date
ee75668 
issue #187
rsoika added a commit that referenced this issue Aug 19, 2016
@rsoika
changed behavior - created or modified != null => new workitem
120cef9 
issue #187
@rsoika rsoika closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
3.9.0
Development

No branches or pull requests
1 participant
@rsoika