Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update example-setstate.mdx #833

Merged
merged 1 commit into from Aug 4, 2021

Conversation

VladislavMurashchenko
Copy link
Contributor

@VladislavMurashchenko VladislavMurashchenko commented Jul 30, 2021

Moved id generation for new todos out of reducers to keep them pure.

The main behind this PR is, that reducers should be pure functions. And it would be great if docs of other libs also don't violate this rule in their examples.
image

Moved id generation for new todos out of reducers to keep them pure
@netlify
Copy link

@netlify netlify bot commented Jul 30, 2021

✔️ Deploy Preview for quizzical-lovelace-dcbd6a ready!

🔨 Explore the source changes: 2569c0a

🔍 Inspect the deploy log: https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/6104228cf80543000766b103

😎 Browse the preview: https://deploy-preview-833--quizzical-lovelace-dcbd6a.netlify.app

@VladislavMurashchenko
Copy link
Contributor Author

@VladislavMurashchenko VladislavMurashchenko commented Aug 3, 2021

@mweststrate mweststrate merged commit 1195510 into immerjs:master Aug 4, 2021
5 checks passed
@mweststrate
Copy link
Collaborator

@mweststrate mweststrate commented Aug 4, 2021

Thanks for noticing! Updated the sandboxes as well

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 31, 2021

🎉 This PR is included in version 9.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants