font-lock error #53

Closed
ptrv opened this Issue Mar 21, 2013 · 7 comments

2 participants

@ptrv

I have this simple lua file

-- A syntax error caused by a missing quote
--
-- Checkers: lua

print "oh no"

print "hello world"

When I open the file I get the following error:
Error during redisplay: (jit-lock-function 1) signaled (wrong-type-argument stringp lua-comment-start-skip)

Only line 1 is colored, all other lines do not have syntax coloring.

I am on Emacs 24.3 and latest lua-mode.

@immerrr
Owner

Oh, hey, a follow-up from flycheck bug. Nice :)

Thanks for the report, I confirm I see the same.

@immerrr immerrr added a commit that referenced this issue Mar 21, 2013
@immerrr Post-refactoring fix: evaluate string variables in font-lock-defaults…
… value

Should fix issue #53.
a1dc850
@immerrr
Owner

Yes, my bad. Didn't verify last set of changes properly. Should be good now.

@immerrr immerrr closed this Mar 21, 2013
@ptrv

Yes, can confirm, it works now. Thanks for the quick fix.

@immerrr
Owner

Btw, @ptrv, does lua-mode still hang flycheck?

@ptrv

I only had the problem with emacs on Ubuntu installed from https://launchpad.net/~cassou/+archive/emacs. I can't remember if it was only version 24.2 or also emacs-snapshot. I use now a self compiled 24.3 version and I don't have the hang problem anymore. I tested it also with emacs-snapshot and the problem seems to be gone. As I remember @lunaryorn also had this issue only with emacs on Ubuntu not on Mac OS.

Btw, I wanted to test the new lua-mode version with my 24.2 install but there is an error loading the mode:

Debugger entered--Lisp error: (error "`cl-labels' with dynamic scoping is not implemented")

though I have the compatibility package cl-lib-0.2 installed

@immerrr
Owner

Well, I use 24.2 installed from exactly that location on daily basis in Ubuntu and I don't have that issue.

As for the cl-labels issue, I'm going to rewrite that code anyways, so I don't see the point in fixing it now, but you can try something like that locally:

sed -i 's/(lua--cl-labels/(flet/' lua-mode.el
@ptrv

This issue is not a problem for me, because i use 24.3. Just wanted to report the error I got with 24.2. But if it works for you, then probably something was wrong with my 24.2 setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment