Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mipmapping #243

Merged
merged 2 commits into from Jan 22, 2021
Merged

Add support for mipmapping #243

merged 2 commits into from Jan 22, 2021

Conversation

cabanier
Copy link
Member

@cabanier cabanier commented Jan 21, 2021 •
edited by pr-preview bot

Closes #237

馃挜 Error: 500 Internal Server Error 馃挜

PR Preview failed to build. (Last tried on Jan 22, 2021, 9:49 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

馃毃 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

馃敆 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

toji
toji approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only question is, do we want to leave a note in here (even if non-normative) that indicates that user agents can perform automatic mip-mapping on projection layers if desired?

@cabanier
Copy link
Member Author

LGTM! Only question is, do we want to leave a note in here (even if non-normative) that indicates that user agents can perform automatic mip-mapping on projection layers if desired?

I was on the fence about adding this. Since you brought it up, I will add a non-normative note.

@cabanier cabanier merged commit a39b124 into immersive-web:main Jan 22, 2021
@cabanier cabanier deleted the mipmapping branch January 22, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support mipmapping in composition layers
2 participants
@cabanier @toji