-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for depth testing across layers #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to make a general request to do some research and see if there's a specific use case that drove the OpenXR design of the same feature, which allows depth sorting to be toggled per-layer, but otherwise this seems OK with one naming nit.
I asked internally and that flag is so the system can make sure that quad/cylinder layers can always be drawn on top of the scene. For instance, if you hit the Oculus button during an immersive session, the dialog that then pops up should always take precedence over what the browser is drawing. Same with the keyboard which should always be in front. |
Agreed. Thanks for looking into it! |
Looks like that in Oculus2 there are a flag, but still not working. |
Yes, there is a flag but the feature is not enabled yet. The flag will just trigger all the logic in the browser but the OS won't honor it. |
Closes #135
Preview | Diff