Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for depth testing across layers #271

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

cabanier
Copy link
Member

@cabanier cabanier commented Nov 1, 2021

Closes #135


Preview | Diff

Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to make a general request to do some research and see if there's a specific use case that drove the OpenXR design of the same feature, which allows depth sorting to be toggled per-layer, but otherwise this seems OK with one naming nit.

webxrlayers-1.bs Outdated Show resolved Hide resolved
@cabanier
Copy link
Member Author

cabanier commented Nov 2, 2021

I'd like to make a general request to do some research and see if there's a specific use case that drove the OpenXR design of the same feature, which allows depth sorting to be toggled per-layer, but otherwise this seems OK with one naming nit.

I asked internally and that flag is so the system can make sure that quad/cylinder layers can always be drawn on top of the scene.

For instance, if you hit the Oculus button during an immersive session, the dialog that then pops up should always take precedence over what the browser is drawing. Same with the keyboard which should always be in front.
I don't think that's a particular concern for WebXR.

@toji
Copy link
Member

toji commented Nov 3, 2021

Agreed. Thanks for looking into it!

@cabanier cabanier merged commit 2e01439 into immersive-web:main Nov 3, 2021
@cabanier cabanier deleted the deptsorting branch November 3, 2021 16:16
github-actions bot added a commit that referenced this pull request Nov 3, 2021
SHA: 2e01439
Reason: push, by @cabanier

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@eXponenta
Copy link

Looks like that in Oculus2 there are a flag, but still not working.
I'm tried to use it - session starts, but quad layers not sorted between themselfs, need to sort manually by Z across camera.

@cabanier
Copy link
Member Author

Yes, there is a flag but the feature is not enabled yet. The flag will just trigger all the logic in the browser but the OS won't honor it.
We'll announce when it's ready for experimentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depth testing across layers
3 participants