Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRLayers should never be composited using 'lighter' #23

Closed
rcabanier opened this issue Sep 3, 2019 · 3 comments
Closed

XRLayers should never be composited using 'lighter' #23

rcabanier opened this issue Sep 3, 2019 · 3 comments
Labels
composition
Milestone
November 2019

Comments

@rcabanier
Copy link
Contributor

rcabanier commented Sep 3, 2019 •
edited

The spec currently says:

When performing additive environment blending, the rendered buffers obtained by the XR Compositor are composited using lighter blending before being presented on the XR device.

This is incorrect. On devices with additive blending the layers must be composited using source-over as usual. The result of that composition is then composited with the real world using lighter
@cwilso cwilso added this to the September 2019 milestone Sep 9, 2019
@Manishearth
Copy link
Contributor

#25

@Manishearth Manishearth mentioned this issue Sep 12, 2019
Closed
Manishearth added a commit to Manishearth/webxr-ar-module that referenced this issue Sep 12, 2019
@Manishearth
Avoid making it sound like XRLayers are composited with each other (f…
c7530b3 
…ixes immersive-web#23)
@Manishearth
Copy link
Contributor

@rcabanier could you make a PR that addresses this?

@Manishearth
Copy link
Contributor

Closing since we're not quite sure what to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
composition
Projects
None yet
Milestone
November 2019
Development

Successfully merging a pull request may close this issue.

Clean up additive blend mode, mention premultiplied alpha Manishearth/webxr-ar-module
3 participants
@cwilso @Manishearth @rcabanier