Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention grasp profile #68

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Mention grasp profile #68

merged 1 commit into from
Nov 17, 2020

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented Nov 16, 2020

index.bs Outdated
@@ -138,6 +138,8 @@ An {{XRInputSource}} is a <dfn>physical hand input source</dfn> if it tracks a p

[=Physical hand input sources=] MUST include the [=XRInputSource/input profile name=] of "generic-hand-select" in their {{XRInputSource/profiles}}.

For many [=physical hand input sources=], there can be overlap between the gestures used for the [=primary action=] and the squeeze action. Since content may assume that these are independent events, user agents MAY, instead of surfacing the squeeze action as the [=primary squeeze action=], surface it as an additional "grasp button", using an input profile derived from the "generic-hand-select-grasp" profile.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs rephrasing or an explanatory note because context is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an example

@cabanier
Copy link
Member

LGTM!

@Manishearth Manishearth merged commit f6a87d6 into master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants