Skip to content

Added additional clarification in security section #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

Added additional clarification in security section #87

merged 1 commit into from
Mar 2, 2021

Conversation

cabanier
Copy link
Member

@cabanier cabanier commented Mar 2, 2021 •
edited by pr-preview bot
Loading

@Manishearth Manishearth merged commit d28eb78 into immersive-web:main Mar 2, 2021
@Manishearth
Copy link
Contributor

A more thorough exploration of what "noising" and "rounding" means would be good to have, but this is a good start!

@cabanier
Copy link
Member Author

cabanier commented Mar 2, 2021

Thank you but I didn't want to pull it in just yet :-)
I wanted our security people to take a look first.

@cabanier
Copy link
Member Author

cabanier commented Mar 2, 2021

No big deal though. If they want changes, I will create another PR.

@Manishearth
Copy link
Contributor

Oh yeah absolutely, no rush. Having just these changes is quite good already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabanier @Manishearth