Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XRLayer base type. #688

Merged
merged 2 commits into from Jun 10, 2019

Conversation

Projects
None yet
4 participants
@toji
Copy link
Member

commented Jun 10, 2019

/fixes #268

Also changed baseLayer to only accept an XRWebGLLayer. This can be
extended in the future in a few ways:

  • Re-introduce XRLayer and change baseLayer to take one.
  • Update baseLayer to accept a union of layer types.
  • Leave baseLayer as WebGL-only and enforce that new layer types must
    use whatever layer array mechanism is introduced.
Remove XRLayer base type.
Also changed `baseLayer` to only accept an `XRWebGLLayer`. This can be
extended in the future in a few ways:

 - Re-introduce XRLayer and change `baseLayer` to take one.
 - Update `baseLayer` to accept a union of layer types.
 - Leave `baseLayer` as WebGL-only and enforce that new layer types must
   use whatever layer array mechanism is introduced.

@toji toji added this to the June 2019 milestone Jun 10, 2019

@toji toji requested review from Artyom17 and NellWaliczek Jun 10, 2019

@NellWaliczek
Copy link
Member

left a comment

LGTM. Just have a few nits.

Show resolved Hide resolved explainer.md Outdated
Show resolved Hide resolved index.bs Outdated
@NellWaliczek
Copy link
Member

left a comment

Thanks!

@toji toji merged commit 4a8df20 into master Jun 10, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
ipr PR deemed acceptable.
Details

@toji toji deleted the remove-xrlayer branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.