Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add country boundaries file to image #80

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

pokjay
Copy link
Contributor

@pokjay pokjay commented Jul 7, 2024

Add country boundaries file to image. A geoJSON file containing boundary polygons for each country from Natural Earth.

Will be used for geocoding images with remote locations which the current cities geocoding fails: immich-app/immich#10950

Built and tested locally.

@zackpollard
Copy link
Contributor

zackpollard commented Jul 7, 2024

I appreciate that this may be time consuming to compute, but I would want to understand
1.) how we compute this file and
2.) have the scripts for doing that in this repo and the transformations generated within this repo or another repo in the Immich org.

We can almost certainly do this on a schedule in a GitHub actions runner, so I'd prefer we do that than just link out to another users repo to pull the file.

If I've misunderstood how this works then I am happy to be corrected, I thought there was some preprocessing required we couldn't do on the Immich database

@pokjay
Copy link
Contributor Author

pokjay commented Jul 7, 2024

I appreciate that this may be time consuming to compute, but I would want to understand 1.) how we compute this file and 2.) have the scripts for doing that in this repo and the transformations generated within this repo or another repo in the Immich org.

We can almost certainly do this on a schedule in a GitHub actions runner, so I'd prefer we do that than just link out to another users repo to pull the file.

If I've misunderstood how this works then I am happy to be corrected, I thought there was some preprocessing required we couldn't do on the Immich database

After the last discussion and with bo0tzz idea I relooked at it, and there's actually no need for any preprocessing!
I use the official Github repo of the Natural Earth project, and they store a geoJSON file with the country boundaries. This is easy to read and load to the DB, which is what I do in the other PR.

(You can see in https://www.naturalearthdata.com/about/contact-us/ that nvkelso is/was a Project Manager in Natural Earth)

@zackpollard zackpollard enabled auto-merge (squash) July 17, 2024 20:12
@zackpollard zackpollard changed the title feat: Add country boundaries file to image feat: add country boundaries file to image Jul 17, 2024
@zackpollard zackpollard enabled auto-merge (squash) July 17, 2024 20:12
@zackpollard zackpollard merged commit f8504e0 into immich-app:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants