Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] photos should have a permanent url #2906

Closed
2 of 3 tasks
uhthomas opened this issue Jun 21, 2023 · 8 comments
Closed
2 of 3 tasks

[BUG] photos should have a permanent url #2906

uhthomas opened this issue Jun 21, 2023 · 8 comments
Assignees

Comments

@uhthomas
Copy link
Member

The bug

Photos don't have a permanent link when viewed, which means Immich will reset back to the main photos page when the page is refreshed. It also means the link can't be copied or opened in a new tab for whatever reason.

image

The OS that Immich Server is running on

N/A

Version of Immich Server

v1.62.1

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

N/A

Additional information

No response

@uhthomas
Copy link
Member Author

Even though albums generate a full URL like /albums/:id/photos/:id, a refresh forces the user back to /albums/:id. Seems a bit pointless and should also be fixed.

@alextran1502
Copy link
Contributor

This is a more complicated behavior that we haven't gotten around to implementing. By navigating to the specific URL, the asset will need to be determined which time bucket it is in to allow proper navigation.

@uhthomas
Copy link
Member Author

uhthomas commented Jul 3, 2023

@alextran1502 I don't think it really matters? I don't think even Google Photos handles that. I would be happy if a direct link just handed the user back to the top of the page.

@jrasm91
Copy link
Contributor

jrasm91 commented Jul 3, 2023

Google does handle direct links to assets, and the previous/next arrows work within the context too.

@uhthomas
Copy link
Member Author

uhthomas commented Jul 3, 2023

Yes, sorry, I am aware that Google handles those cases correctly.

How does Google handle exiting from the asset?

@jrasm91
Copy link
Contributor

jrasm91 commented Jul 3, 2023

It goes back to the album/context as you would expect

@jrasm91
Copy link
Contributor

jrasm91 commented Aug 6, 2023

With some of the recent changes in the asset grid implementation, I think it should be easier to add this now. For views that use the asset grid, we should be able to add this feature.

@alextran1502
Copy link
Contributor

Implemented #8532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants