Skip to content

fix: various actions workflow security improvements - #17651

Merged
alextran1502 merged 8 commits into
mainfrom
fix/actions-security
Apr 18, 2025
Merged

fix: various actions workflow security improvements#17651
alextran1502 merged 8 commits into
mainfrom
fix/actions-security

Conversation

@bo0tzz

@bo0tzz bo0tzz commented Apr 16, 2025

Copy link
Copy Markdown
Member

I hadn't realised these push to the registry too :x
@bo0tzz bo0tzz added the fix:formatting Automatically fix formatting on a PR label Apr 16, 2025
@github-actions github-actions Bot removed the fix:formatting Automatically fix formatting on a PR label Apr 16, 2025
@bo0tzz bo0tzz added the fix:formatting Automatically fix formatting on a PR label Apr 16, 2025
@github-actions github-actions Bot removed the fix:formatting Automatically fix formatting on a PR label Apr 16, 2025
@bo0tzz
bo0tzz requested a review from zackpollard April 16, 2025 19:03

@jrasm91 jrasm91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/cache-cleanup.yml Outdated
Comment thread .github/workflows/docker.yml Outdated
Comment thread .github/workflows/docker.yml Outdated
@alextran1502
alextran1502 merged commit 5049309 into main Apr 18, 2025
@alextran1502
alextran1502 deleted the fix/actions-security branch April 18, 2025 20:10
savely-krasovsky pushed a commit to savely-krasovsky/immich that referenced this pull request Jun 8, 2025
* fix: set persist-credentials explicitly for checkout

https://woodruffw.github.io/zizmor/audits/#artipacked

* fix: minimize permissions scope for workflows

https://woodruffw.github.io/zizmor/audits/#excessive-permissions

* fix: remove potential template injections

https://woodruffw.github.io/zizmor/audits/#template-injection

* fix: only pass needed secrets in workflow_call

https://woodruffw.github.io/zizmor/audits/#secrets-inherit

* fix: push perm for single-arch build jobs

I hadn't realised these push to the registry too :x

* chore: fix formatting

* fix: $

* fix: retag job quoting

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants