renovate: mobile ignore *_plus plugins #8415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlong-tanwen
added
the
dependencies
This was referenced Mar 31, 2024
plus plugins are ignored from renovate updates until the jdk is migrated to 17
shenlong-tanwen
force-pushed
the
renovate/ignore-plus-plugins
branch
from
4623b05
to
f69dbde
Compare
Deploying immich with
|
| Latest commit: |
f69dbde
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://85231d32.immich.pages.dev |
| Branch Preview URL: | https://renovate-ignore-plus-plugins.immich.pages.dev |
This was referenced Mar 31, 2024
bo0tzz
approved these changes
Mar 31, 2024
|
You can instead just close the pull requests. |
Yes but it'll take a while for us to update our JDK to Java 11. None of the other plugins have such weird build requirement. We can remove this ignore rule when we update them. Edit: Oh, I just realized that closing PRs raised by renovate automatically puts it in an ignore list until we manually upgrade it to that version. Then maybe we can handle it as such and close this PR then. |
|
That's what I was thinking. It will still track the dependency and that way we don't forget about it, but we can ignore it until the sdk is updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made