Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): enhance ux/ui of the album list page #8499

Merged
merged 10 commits into from
Apr 5, 2024

Conversation

Ethan13310
Copy link
Contributor

This PR add some features and fixes to the album list page.

Album Grouping

With this new feature, albums can now be grouped by year or owner (or not grouped at all). This can be very useful to not get lost when having a lot of albums, that even are sometimes similar.

GroupFeature

  • This works both on "Covers" and "List" views.

GroupFeatureList

  • Albums are first grouped, then sorted inside of those groups.
  • Group sorting can be either ascending or descending.
  • Group by drop-down is located next to the Sort by one. The two buttons on the right are Expand all and Collapse all. They are not displayed when No grouping is selected.

GroupByDropdown

  • Groups can be collapsed (saved in the local storage).
Collapse.mp4

Other UI Changes

  • Album cards now display the month and year of the photos.
    • Same month and year: Jan 2024
    • Different months, same year: Jan - Mar 2024
    • Different year: Sep 2023 - Feb 2024
  • Album cards now display the title over up to 2 lines. If the title is longer, it is cropped with an ellipsis (no change).

AlbumCard

  • "Edit Album" modal design has been slightly changed.

EditAlbumModal

Quality of Life

Album List

  • The context menu now has 4 options: Download, Edit, Share and Delete.

AlbumContextMenu

  • The context menu can now be displayed by right-clicking on an album card.
  • The context menu is now available on the list view (both Edit and Remove buttons have been removed).
  • The context menu is now available on the "Sharing" page, with only 1 option: Download.
  • The search feature now ignores accents.

Album View

  • When one and only one photo is selected, the context menu now displays the option Set as album cover.

SetAsAlbumCover

Fixes

  • Sorting by album title now works properly with any locale.
  • High-resolution album thumbnails are no longer loaded, as they did not bring any quality improvements and can even decrease the apparent quality on Chromium-based browsers.
  • Context menus cannot overflow vertically anymore.
  • When updating an album (edit title, share...), changes are now correctly displayed in the album list.
  • On the "Sharing" page, getUserById() is no more called for each album card since this info is already available in AlbumResponseDto.

@alextran1502
Copy link
Contributor

Nice! <3

@alextran1502
Copy link
Contributor

Hello, can you enable the option to let contributors push directly to the PR? I usually update a PR with main when I perform some manual testings with it

@Ethan13310
Copy link
Contributor Author

Ethan13310 commented Apr 4, 2024

Hello, can you enable the option to let contributors push directly to the PR? I usually update a PR with main when I perform some manual testings with it

Hi! It's done

@alextran1502
Copy link
Contributor

alextran1502 commented Apr 5, 2024

Hello, what property do you use to group albums together by year?

Ah I see you are using the oldest asset in an album

@alextran1502 alextran1502 enabled auto-merge (squash) April 5, 2024 19:15
@alextran1502 alextran1502 merged commit 8f981b6 into immich-app:main Apr 5, 2024
23 checks passed
@waclaw66
Copy link
Contributor

waclaw66 commented Apr 6, 2024

I would make year/owner labels bit smaller, 2xl 2024 is big enough imho.

obrazek

@Ethan13310 Ethan13310 deleted the feat/better-album-list-ui branch April 7, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants