Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: Translation nightly features #46

Open
TheDan64 opened this issue Apr 2, 2019 · 7 comments
Open

Tracking Issue: Translation nightly features #46

TheDan64 opened this issue Apr 2, 2019 · 7 comments

Comments

@TheDan64
Copy link
Contributor

@TheDan64 TheDan64 commented Apr 2, 2019

This is the tracking issue for generated code which requires nightly to run:

  • Assembly - asm - rust-lang/rust#29722
  • Intrinsics for atomic operations - core_intrinsics - Unlikely to ever be stabilized itself, no tracking issue
  • Ptr to ptr offset calculation - ptr_wrapping_offset_from - rust-lang/rust#41079
  • Labels for breaks in relooper - label_break_value - rust-lang/rust#48594
  • Opaque extern types - extern_types - rust-lang/rust#43467
  • Thread Local variables - thread_local - rust-lang/rust#29594
  • Cast const ptr to usize - const_raw_ptr_to_usize_cast - rust-lang/rust#51910
  • Cast const slice to pointer - const_slice_as_ptr - This may have been removed or stabilized?
  • C-compatible variadic functions - c_variadics - rust-lang/rust#44930
  • Libc types - libc - Now generating Cargo.toml files which use the libc crate
@rinon
Copy link
Contributor

@rinon rinon commented Apr 11, 2019

Since libc is on crates.io and rustc errors when we use the internal version, we should drop that off the list of nightly features.

Loading

@bjorn3
Copy link

@bjorn3 bjorn3 commented Aug 29, 2019

Intrinsics for atomic operations - core_intrinsics - Unlikely to ever be stabilized itself, no tracking issue

Maybe cast the pointer from say *mut u64 to *mut AtomicU64 and then use the normal AtomicU64 methods on it.

Loading

@panstromek
Copy link

@panstromek panstromek commented Jul 19, 2020

Note about ptr_offset_from stabilization:

Method wrapping_offset_from (which is often used in c2rust output) has been deprecated since 1.46 and it is being removed in ptr_offset_from stabilization PR: rust-lang/rust#74238

Loading

@chrysn
Copy link
Contributor

@chrysn chrysn commented Sep 22, 2020

Assembly is now tracked at rust-lang/rust#70173 -- but without any plan for stabilization; see #306. Unless the asm transpilation is significantly reworked (to produce Rust asm rather than llvm_asm), this now falls in the "unlikely to be stabilized" category.

Loading

@OvermindDL1
Copy link

@OvermindDL1 OvermindDL1 commented Oct 20, 2020

Method wrapping_offset_from (which is often used in c2rust output) has been deprecated since 1.46 and it is being removed in ptr_offset_from stabilization PR: rust-lang/rust#74238

And looks like it's entirely gone now, says the feature doesn't exist and the wrapping_offset_from call no longer exists in the source.

Loading

@fanninpm
Copy link

@fanninpm fanninpm commented Dec 22, 2020

And looks like it's entirely gone now, says the feature doesn't exist and the wrapping_offset_from call no longer exists in the source.

It was removed in August.

Loading

@XVilka
Copy link

@XVilka XVilka commented Dec 23, 2020

I think it worth to pin this issue, otherwise it's easy to miss and one of the most important, imho.

Loading

@thedataking thedataking pinned this issue Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants