ast-exporter: In VisitExpr, handle when Begin and End start off in different macros#1795
Open
Rua wants to merge 3 commits into
Open
ast-exporter: In VisitExpr, handle when Begin and End start off in different macros#1795Rua wants to merge 3 commits into
VisitExpr, handle when Begin and End start off in different macros#1795Rua wants to merge 3 commits into
Conversation
Rua
force-pushed
the
macro-convergence
branch
6 times, most recently
from
749ed39 to
be5a0e0
Compare
Rua
force-pushed
the
macro-convergence
branch
3 times, most recently
from
fb66fca to
ad4d22e
Compare
Rua
force-pushed
the
macro-convergence
branch
2 times, most recently
from
180b3e7 to
b767dbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some bugs in the logic here that were preventing some macro expansions from working correctly.
The first commit is just refactoring, because there was some old code left in there for supporting Clang versions before 7, which is no longer officially supported by c2rust according to the readme.