OrderedSet is changing item ordering (@4.0.0-rc.11+)

[pixmaster]

const { OrderedSet, Map } = require('immutable@4.0.0-rc.11')
const i=[2];
OrderedSet([ Map({b:1, a:true}), Map({b:2,a:true}), Map({b:3,a:true}) ])
  .map((t) => {
  if (i.includes(t.get('b'))) return t.set('a', false);
  return t;
  })
  .toJS()

Result

[Soreine]

Your example looks like the expected behavior.
During the map, if you return a different value, then it will probably remove the old value and add the new value, effectively pushing it to the end of the new OrderedSet

[pixmaster]

@Soreine it only looks like, because I expect than OrderedSet don't change order in any cases. What the sense have type is OrderedSet if that changes order? Especially till 4.0.0-rc.11 it worked as I expected. In our project we updated Immutable package and face this issue. I think it isn't as most of dev expected.

[B-R-Bender]

same with me, I've expected order to be persist
is there any workaround you end up with? @pixmaster @Soreine

[B-R-Bender]

my workarount is to converto to List first and after updates is done convert it back to OrderedSet

return lineData.toList().map(dataItem => dataItem.update(
                            Y_VALUE,
                            value => value + prevLineData.getIn([dataItem.get(X_VALUE), Y_VALUE])
                        )).toOrderedSet();

[jdeniau]

Thank you for your bug report. The immutable-js oss fork will soon be merged and a fix for this issue has been included in #1833. Once this PR is merged, this issue will be resolved in the main branch. We will then do our best to to release the 4.0.0 version.

Commit reference: 37c34ec

[jdeniau]

Hi!
The 4.0.0-rc.14 version has been released and should fix this issue.
Feel free to test it and re-open this issue if the issue is still present.
Thank you!