-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for symbols as keys in Maps. #1392
Closed
Closed
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5c6571f
Adds support for symbols as keys in Maps.
abacaphiliac 7b7b799
checks for existence of `Object.getOwnPropertySymbols` before using i…
abacaphiliac a731e4f
Merge remote-tracking branch 'facebook/master' into map-key-symbols
abacaphiliac 9151ed6
avoid key concatenation in ObjectSeq when Symbols are not available.
abacaphiliac cf479f7
update shallowCopy to handle Symbol keys in objects.
abacaphiliac c0629bc
consolidate ObjectSeq key initializer and remove unnecessary else con…
abacaphiliac 7dce2e4
Skip concat in Map instantiation and loop in shallowCopy when objects…
abacaphiliac cb41214
Merge remote-tracking branch 'facebook/master' into map-key-symbols
abacaphiliac 6f5a47f
removes Symbol-handling logic from Seq and shallowCopy due to perform…
abacaphiliac 7963603
Merge remote-tracking branch 'facebook/master' into map-key-symbols
abacaphiliac c6dad00
Renames Map.ownEntries to Map.fromOwnEntries, adds explicit test case…
abacaphiliac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should at least avoid concatenating in the common case where there are no symbols defined in the object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course.