Avoid hitting real API in test #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithbro-imx
commented
Oct 23, 2023
| import { ImxConfiguration, ImxModuleConfiguration, createImmutableXConfiguration } from './config'; | ||
|
|
||
| describe('ImmutableXClient', () => { | ||
| it('should instantiate a SANDBOX ImmutableXClient', async () => { | ||
| it.skip('should instantiate a SANDBOX ImmutableXClient', async () => { |
There was a problem hiding this comment.
Couldn't get this one to work
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sandbox is currently unavailable and this is causing all PRs to fail due a failing test which is trying to get a 200 response from our sandbox API.
Instead, use an Axios adapter to intercept the request and check the relevant info that's of interest.
Customer Impact
No impact.
Added
Changed
Deprecated
Removed
Fixed
Security
Things worth calling out
Before submitting the PR, please consider the following:
feat:,fix:,chore:,docs:, orrefactor:.