Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dx 2821/port core sdk v3 #1820

Merged
merged 22 commits into from
May 29, 2024
Merged

Dx 2821/port core sdk v3 #1820

merged 22 commits into from
May 29, 2024

Conversation

kaihirota
Copy link
Contributor

@kaihirota kaihirota commented May 22, 2024

Hi👋, please prefix this PR's title with:

  • breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
  • feat:, fix:, refactor:, docs:, or chore:.

Summary

Detail and impact of the change

Added

  • addition of registrationV4ContractAddress to config in packages/x-client/src/config/index.ts
  • addition of getWithdrawalBalanceWorkflow
  • addition of getYCoordinate to StarkSigner interface, StandardStarkSigner class and ImxSigner

Changed

  • prepareWithdrawal now uses v2/withdrawal api
  • completeWithdrawal now uses Registration v4 contract, and user is no longer required to be registered on-chain
  • addition of StarkSigner to complete withdrawal params
    before
    return completeEthWithdrawalAction({
        ethSigner, starkPublicKey, config,
    });
    
    after
    return completeEthWithdrawalAction({
        ethSigner, starkSigner, starkPublicKey, config,
    });
    

Deprecated

Removed

Fixed

Security

Anything else worth calling out?

Tests

Eth Register and withdraw
https://sepolia.etherscan.io/tx/0x6018298bdb247cd55b02ac6473d1b7e290c2f1a21df43c11947b12528ab74e8c

NFT withdrawal
https://etherscan.io/tx/0x4e87dd31765476708558a09f16819f6fdfaf0bf9f4666918ca3ac706b062b122#eventlog

@kaihirota kaihirota self-assigned this May 22, 2024
@kaihirota kaihirota marked this pull request as ready for review May 28, 2024 05:30
@kaihirota kaihirota requested review from a team as code owners May 28, 2024 05:30
@kaihirota kaihirota added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 8da642d May 29, 2024
14 checks passed
@kaihirota kaihirota deleted the DX-2821/port-core-sdk-v3 branch May 29, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants