-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dx 2821/port core sdk v3 #1820
Merged
Merged
Dx 2821/port core sdk v3 #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mutable-sdk into DX-2821/port-core-sdk-v3
carleeto
approved these changes
May 27, 2024
brayansdt
approved these changes
May 28, 2024
wdinau
approved these changes
May 28, 2024
carmen0208
approved these changes
May 28, 2024
mimi-imtbl
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi👋, please prefix this PR's title with:
breaking-change:
if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.feat:
,fix:
,refactor:
,docs:
, orchore:
.Summary
Detail and impact of the change
Added
registrationV4ContractAddress
to config inpackages/x-client/src/config/index.ts
getWithdrawalBalanceWorkflow
getYCoordinate
toStarkSigner
interface,StandardStarkSigner
class andImxSigner
Changed
prepareWithdrawal
now usesv2/withdrawal
apicompleteWithdrawal
now uses Registration v4 contract, and user is no longer required to be registered on-chainStarkSigner
to complete withdrawal paramsbefore
Deprecated
Removed
Fixed
Security
Anything else worth calling out?
Tests
Eth Register and withdraw
https://sepolia.etherscan.io/tx/0x6018298bdb247cd55b02ac6473d1b7e290c2f1a21df43c11947b12528ab74e8c
NFT withdrawal
https://etherscan.io/tx/0x4e87dd31765476708558a09f16819f6fdfaf0bf9f4666918ca3ac706b062b122#eventlog