New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev wars broken with 2.1.0 #111

Closed
tobias opened this Issue Oct 1, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@tobias
Member

tobias commented Oct 1, 2015

A dev war created with lein-immutant 2.0.0 that uses Immutant 2.1.0 will fail to start in WildFly, throwing a CNFE for fns in the immutant.wildfly ns. This is caused by the classpath code in deploy-tools, which looks for a wildfly.*?.jar on the classpath to know if it should add org.immutant/wildfly as a dependency. Before 2.1.0, there were no jars with wildfly in the name on the classpath. With 2.1.0, we have:

[org.immutant/web "2.1.0"]
     [org.projectodd.wunderboss/wunderboss-web-undertow "0.9.0"]
       [io.undertow/undertow-core "1.3.0.Beta9"]
         [org.jboss.xnio/xnio-api "3.4.0.Beta1"]
           [org.wildfly.common/wildfly-common "1.0.0.Alpha2"]
             [org.wildfly.security/wildfly-security-manager "1.1.2.Final"]

which makes the plugin think org.immutant/wildfly is already on the classpath, so it doesn't get added. The fix is to make that detection regex more exact.

tobias added a commit to immutant/deploy-tools that referenced this issue Oct 1, 2015

@tobias tobias closed this in fde0d07 Oct 1, 2015

tobias added a commit to immutant/boot-immutant that referenced this issue Oct 1, 2015

Update to latest deploy-tools to fix dev war issue
The boot plugin suffers from the same bug as
immutant/lein-immutant#111, so this fixes it.

It also updates us to the latest fntest which works better against EAP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment