Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ISerializer needs to be binary, not text-based #2

Closed
ppanyukov opened this issue Jan 25, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@ppanyukov
Copy link
Contributor

commented Jan 25, 2015

The existing ISerializer interface serializes form object to string, and deseralizes from string to object.

This basically prevents form using any serializer which do not produce strings, e.g. binary serializers (BinaryFormatter, protobufs etc). After all, not everyone wants to store their objects as JSON in Redis.

More than that, Redis does require binary values (byte[]), and StackExchange.Redis implicitly converts strings into byte[]. Might just as well this at the ISerializer level.

I have a pull request for this change if interested.

@imperugo

This comment has been minimized.

Copy link
Owner

commented Jan 25, 2015

Hi @ppanyukov
It makes sense to change from string to byte[]. In this case is easier also create a BinaryFormatter.

Tomorrow I'll clone you repo, run the tests, merge the PR and release a new version on NuGet

Thanks.

@imperugo imperugo closed this in #3 Jan 26, 2015

imperugo pushed a commit that referenced this issue Nov 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.