refactor(s3): update upload condition #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucienShui
force-pushed
the
refactor/s3
branch
from
4a8ec12 to
425cd9c
Compare
Copilot finished reviewing on behalf of
ycdzj
November 17, 2025 04:08
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors S3 upload handling by removing content-type enforcement from presigned POST requests and adds file type validation at the application layer. The key changes include moving from S3-level content-type conditions to server-side file extension validation.
- Removed
contentTypeparameter from S3 upload form generation, allowing clients to specify content-type freely - Added whitelist-based file extension validation in
FilesService.createFile()with a set of allowed file types - Introduced file existence verification in
ResourcesService.createResource()using S3 HEAD requests
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/s3/s3.service.ts | Removed contentType parameter and related conditions/fields from generateUploadForm method |
| src/files/files.service.ts | Added ALLOWED_FILE_EXTENSIONS constant, file type validation in createFile, made mimetype optional, removed mimetype parameter from generateUploadForm, added headFile method |
| src/namespace-resources/namespace-resources.service.ts | Removed mime-types import and fallback logic, removed mimetype parameter from generateUploadForm call |
| src/resources/resources.service.ts | Added FilesService injection and file existence check using headFile in createResource |
| src/resources/resources.module.ts | Added FilesModule to module imports |
| src/i18n/en/resource.json | Added "fileTypeNotSupported" translation |
| src/i18n/zh/resource.json | Added "fileTypeNotSupported" translation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.