Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: disable throwIfNoEntry on Node 14+ #182

Merged
merged 2 commits into from Sep 7, 2022

Conversation

chenxinyanc
Copy link
Contributor

Resolves #181

Kept try...catch block as ESLint still keeps support on v12.22.0+ and throwIfNoEntry is not supported until Node 14 LTS.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

🦋 Changeset detected

Latest commit: 8c3dff0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@chenxinyanc chenxinyanc changed the title Use throwIfNoEntry on Node 14+ perf: Disable throwIfNoEntry on Node 14+ Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

size-limit report 📦

Path Size
./lib/index.js 2.13 KB (0%)
./lib/worker.mjs 168 B (0%)

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@chenxinyanc chenxinyanc changed the title perf: Disable throwIfNoEntry on Node 14+ perf: disable throwIfNoEntry on Node 14+ Sep 7, 2022
JounQin
JounQin approved these changes Sep 7, 2022
@JounQin
Copy link
Collaborator

JounQin commented Sep 7, 2022

@chenxinyanc Thanks for your contribution!

@JounQin JounQin changed the title perf: disable throwIfNoEntry on Node 14+ perf: disable throwIfNoEntry on Node 14+ Sep 7, 2022
@JounQin JounQin merged commit afeb928 into import-js:master Sep 7, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

statSync without throwIfNoEntry: false causes great performance impact when processing typescript imports
2 participants