From f5cfe7c611e1a3218927fda20f995878971731f7 Mon Sep 17 00:00:00 2001 From: Ben Mosher Date: Tue, 5 Jul 2016 07:01:36 -0400 Subject: [PATCH] WIP: commented invalid tests for #416. need good messages --- tests/src/rules/named.js | 13 +++++++++++++ tests/src/rules/namespace.js | 23 +++++++++++------------ 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/tests/src/rules/named.js b/tests/src/rules/named.js index f7ac1670c..403fe63e9 100644 --- a/tests/src/rules/named.js +++ b/tests/src/rules/named.js @@ -240,5 +240,18 @@ ruleTester.run('named', rule, { code: 'import { default as barDefault } from "./re-export"', errors: [`default not found in './re-export'`], }), + + // issue #416 + // todo: update error message to indicate parse issue in deepest module + // test({ + // code: ` + // import { + // Navigation, + // Drawer, + // Layout, + // Content, + // Header, + // } from 'react-mdl'`, + // }), ], }) diff --git a/tests/src/rules/namespace.js b/tests/src/rules/namespace.js index 483416b52..5506fb3b5 100644 --- a/tests/src/rules/namespace.js +++ b/tests/src/rules/namespace.js @@ -107,18 +107,6 @@ const valid = [ ] const invalid = [ - - // issue #416: todo: proper parse error - // test({ - // code: ` - // import * as ReactMDL from 'react-mdl'; - // let Navigation = ReactMDL.Navigation; - // let Drawer = ReactMDL.Drawer; - // let Layout = ReactMDL.Layout; - // let Content = ReactMDL.Content; - // let Header = ReactMDL.Content;`, - // }), - test({code: "import * as foo from './common';", errors: ["No exported names found in module './common'."]}), @@ -199,6 +187,17 @@ const invalid = [ errors: [`'default' not found in imported namespace 'ree'.`], }), + // issue #416: todo: proper parse error + // test({ + // code: ` + // import * as ReactMDL from 'react-mdl'; + // let Navigation = ReactMDL.Navigation; + // let Drawer = ReactMDL.Drawer; + // let Layout = ReactMDL.Layout; + // let Content = ReactMDL.Content; + // let Header = ReactMDL.Content;`, + // }), + ] ///////////////////////