Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] no-extraneous-dependencies: fix package name algorithm #2097

Merged
merged 1 commit into from May 27, 2021
Merged

[Fix] no-extraneous-dependencies: fix package name algorithm #2097

merged 1 commit into from May 27, 2021

Conversation

paztis
Copy link

@paztis paztis commented May 25, 2021 •
edited by ljharb

  • resolve nested package.json problems (a/b/c import will check a, a/b and a/b/c)
  • resolve renamed dependencies: checks the import name and the resolve package name

Fixes #2066. Fixes #2065. Fixes #2058. Fixes #2078.

@ljharb
[Fix] no-extraneous-dependencies: fix package name algorithm
da8d584 
- resolve nested package.json problems (a/b/c import will check a, a/b and a/b/c)
- resolve renamed dependencies: checks the import name and the resolve package name

Fixes import-js#2066. Fixes import-js#2065. Fixes import-js#2058. Fixes import-js#2078.
This was referenced May 25, 2021
Closed
Closed
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 82.53% when pulling d7119ef on paztis:master into 20c373c on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 82.53% when pulling d7119ef on paztis:master into 20c373c on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 82.53% when pulling d7119ef on paztis:master into 20c373c on benmosher:master.

@coveralls
Copy link

coveralls commented May 25, 2021 •
edited

Coverage Status

Coverage increased (+1.04%) to 82.584% when pulling da8d584 on paztis:master into 81b9d24 on benmosher:master.

ljharb
ljharb requested changes May 25, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good, but we'll need to add some regression tests, so this can't happen again.

src/rules/no-extraneous-dependencies.js Show resolved Hide resolved
@ljharb ljharb changed the title [Defect 2066] fix extraneous-dependencies algorithm [Fix] extraneous-dependencies: fix package name algorithm May 25, 2021
@paztis
Copy link
Author

paztis commented May 26, 2021

unit tests added

@mtnowl mtnowl mentioned this pull request May 27, 2021
Closed
@ljharb ljharb changed the title [Fix] extraneous-dependencies: fix package name algorithm [Fix] no-extraneous-dependencies: fix package name algorithm May 27, 2021
@ljharb ljharb merged commit da8d584 into import-js:master May 27, 2021
@tarlepp tarlepp mentioned this pull request May 29, 2021
Closed
@erezrokah erezrokah mentioned this pull request May 30, 2021
Merged
1 task
@tw0517tw tw0517tw mentioned this pull request Jun 1, 2021
Merged
@ekasbohm ekasbohm mentioned this pull request Jun 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@paztis @coveralls @ljharb