Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Core Email Settings #1346

Closed
DevinWalker opened this issue Dec 16, 2016 · 10 comments

Comments

Projects
None yet
4 participants
@DevinWalker
Copy link
Member

commented Dec 16, 2016

Issue Overview

@ravinderk and I discussed revamping Give's email functionality so that it is more flexible and easy to work with.

image

Related Issues
#1215
#1030
#611
#1607
#1623

@mathetos

This comment has been minimized.

Copy link
Member

commented Dec 16, 2016

WOOT! +1000 on this!!

👍 👍 👍 👍 👍

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Dec 27, 2016

This will be really helpful to have all email settings accessible from one place. Here are a couple suggestions.

1346-email-notifications-feedback

See WooCommerce example. Table looks cleaner when descriptions are displayed in tooltips.

@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented Dec 27, 2016

I agree @kevinwhoffman - if we can also customize the cog icon so it's a button as well that would make it even cleaner:

061bb1c4-c31c-11e6-83b6-ed73b1dba569

@mathetos

This comment has been minimized.

Copy link
Member

commented Dec 27, 2016

@DevinWalker Would love a button that says "Edit Email" instead of the cog.

@kevinwhoffman

This comment has been minimized.

Copy link
Member

commented Dec 27, 2016

image

Do you think it makes sense to stick closer to the WP Core UI, where hovering over the row displays links? I can see it being helpful to preview the email directly from this screen, rather than having to click into settings and scroll down to find the preview button.

@mathetos

This comment has been minimized.

Copy link
Member

commented Dec 27, 2016

Hmmm.... I like that idea. Here's all the ideas all in one:

image

  1. The checkmark enables/disables the email dynamically without a page refresh
  2. The descriptions are moved to the tooltips rather than inline below
  3. Hovering over the title shows the "Edit | Preview" links
  4. Clicking the "Preview" link opens the email in a modal -- no page refresh
  5. Recipient can be changed directly, and {tags} can be used. This would update similar to how QuickEdit works in WordPress Core on Pages/Posts
  6. I think having the additional "Edit Email" button at the end is just helpful since the "Edit" is hidden by default until hovering.
@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented Dec 27, 2016

Nice feedback and revisions.

  1. Yes
  2. Yes
  3. Yes
  4. This will just open a new window like it does for now. We can update it to open a modal later.
  5. I don't like this option so much. It looks like our shortcode's click-to-copy field and people aren't really going to be changing the recipients very often so there's not really a need to quick edit.
  6. I like using an icon rather than text
@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Dec 28, 2016

@DevinWalker I showed description under title because we are following the same pattern for core setting. Let me know if you still want to change them

screen shot 2016-12-28 at 3 43 10 pm

@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2016

@ravinderk for the new email settings it looks better to use tooltips for the descriptions. It just looks a lot better when it's in a table.

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Dec 29, 2016

@DevinWalker Alright. I will update UI as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.