Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to send donation notes to the donor if needed #2159

Closed
marutim opened this issue Oct 3, 2017 · 8 comments

Comments

Projects
None yet
6 participants
@marutim
Copy link

commented Oct 3, 2017

Issue Overview

Add the ability to send donation notes to donor when needed. Currently only a donor notes can be added in the donation dashboard and can not be send to the donor. The feature request can be referred to similar thing for order note in WooCommerce.

Expected Behavior

Add the ability to send donation notes to donor when needed

Helpscout link

https://secure.helpscout.net/conversation/437657707/10543/?folderId=672199

Screenshots

Screenshot - WooCommerce
o95um6

Screenshot - Give
donations wp give wordpress

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Oct 4, 2017

@marutim This can be a useful feature.

We can add a checkbox Send the note to donor after note textarea which is unchecked by default.

@DevinWalker What do you think?

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Oct 4, 2017

@marutim Nice suggestion

@ravinderk I also think the same we should have that checkbox

@marutim

This comment has been minimized.

Copy link
Author

commented Oct 4, 2017

Thank you @ravinderk @raftaar1191

@ravinderk Checkbox sounds good to me, but I would like to add another confirmation before sending the Donation notes, something like, when the admin checks the checkbox a send button appears and only when that send button is clicked this note is send. I just want to make sure the notes doesn't get send by accident. These gets sent only when the admin wants to with his/her confirmation.

Let me know how do you think about this.

@mathetos

This comment has been minimized.

Copy link
Member

commented Oct 4, 2017

Keep in mind the consistency that we're looking for with our Settings UI. I believe this option is a Yes/No, which means there should be two selectors, which would mean an inline radio is best here again.

A checkbox unfortunately depends highly on the wording of the label and can still get easily confused, whereas a "yes" | "no" is not easily confused; particularly when the question is "Send this note to the donor by email?"

ravinderk added a commit that referenced this issue Aug 14, 2018

Merge pull request #3590 from WordImpress/issue/2159
Add ability to send donation notes to the donor if needed #2159

@ravinderk ravinderk referenced this issue Aug 14, 2018

Closed

web-doc: add new donation note doc #188

5 of 5 tasks complete

@ravinderk ravinderk closed this Aug 14, 2018

ravinderk added a commit that referenced this issue Sep 10, 2018

@mehul0810

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2018

@ravinderk There is a minor fix required in the default donor note email content. There is "may" word appearing twice as per the screenshot below.
image

You can update the line

"Dear %s,\n\nA note has just been added to your donation:\n\n%s\n\nFor your reference, you may may view your donation details by clicking the link below:\n%s\n\nThank you,\n%s",
for the fix.

Hence, re-opening the issue. Please fix and close the issue.

@mehul0810 mehul0810 reopened this Oct 22, 2018

@ravinderk ravinderk closed this Oct 22, 2018

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Oct 22, 2018

This issue has been fixed in: 540f494

2 similar comments
@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Oct 22, 2018

This issue has been fixed in: 540f494

@ravinderk

This comment has been minimized.

Copy link
Collaborator

commented Oct 22, 2018

This issue has been fixed in: 540f494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.