Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve donor detail page heading #2286

Closed
ravinderk opened this issue Nov 3, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@ravinderk
Copy link
Collaborator

commented Nov 3, 2017

Issue Overview

We can show donor name on donor detail page instead of donor ID.

Donor detail page:
screen shot 2017-11-03 at 1 50 37 pm

WordPress user edit page
screen shot 2017-11-03 at 1 50 27 pm

Todos

  • Development
  • Review Heading
@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 3, 2017

@DevinWalker @mathetos

Slack conversion summary:

‘Edit Donor’ would follow suit with the rest of WP admin. Typically the title of the page reflects the action being taken. It doesn’t include specifics.

I liked your suggestion @Ravinder. I think that ID is of no importance for a user. But, change it to Edit Donor: Mehul Gohil will make a difference to a user. The user will immediately know that he is accessing the donor profile of so and so person and we all know that bigger heading will attract eyesight more easily.

So New heading will look like Edit Donor: {firstname} {lastname}.

@ravinderk ravinderk added this to the 1.8.17 milestone Nov 3, 2017

@DevinWalker

This comment has been minimized.

Copy link
Member

commented Nov 6, 2017

The ID is of some importance. I'd like to see it updated as:

Edit Donor #123: {firstname} {lastname}

@DevinWalker DevinWalker modified the milestones: 1.8.17, 2.0.1 Nov 6, 2017

@DevinWalker

This comment has been minimized.

Copy link
Member

commented Nov 6, 2017

I'm bumping off 1.8.17 as we need to focus on 2.0

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Nov 6, 2017

@ravinderk ravinderk modified the milestones: 2.0.1, 2.0.2 Jan 22, 2018

@DevinWalker DevinWalker modified the milestones: 2.0.2, 2.0.3 Jan 27, 2018

@ravinderk ravinderk modified the milestones: 2.0.3, 2.0.2 Jan 29, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018

@ravinderk ravinderk added the has pr label Jan 29, 2018

@raftaar1191 raftaar1191 referenced this issue Jan 29, 2018

Merged

Change dashboard donor single page title #2732

3 of 3 tasks complete

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018

DevinWalker added a commit that referenced this issue Jan 29, 2018

Merge branch 'release/2.0.2' into issue/339
* release/2.0.2: (22 commits)
  Fix Status issues when importing donation #2725
  Add donor first name and donor last name #2286
  Remove esc html #2286
  Update Donor Single page title #2286
  Open link in a new window - Resolves #2727
  Unrelated code cleanup #2728
  Use WP_Query and not get_posts so meta_query works with new forms meta table - Resolves #2728
  FIx changelog
  Add style to display tr tag in online line #2706
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  ...

# Conflicts:
#	assets/css/give-admin-rtl.css
#	assets/css/give-admin-rtl.min.css
#	assets/css/give-admin.css
#	assets/css/give-admin.min.css
#	assets/sourcemaps/give-admin.css.map

DevinWalker added a commit that referenced this issue Jan 29, 2018

Merge branch 'issue/339' into feature/gutenberg-donation-form-block
* issue/339: (22 commits)
  Fix Status issues when importing donation #2725
  Add donor first name and donor last name #2286
  Remove esc html #2286
  Update Donor Single page title #2286
  Open link in a new window - Resolves #2727
  Unrelated code cleanup #2728
  Use WP_Query and not get_posts so meta_query works with new forms meta table - Resolves #2728
  FIx changelog
  Add style to display tr tag in online line #2706
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.