Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donation statuses not following sort applies on donation listing page. #2400

Closed
ravinderk opened this issue Nov 24, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@ravinderk
Copy link
Collaborator

commented Nov 24, 2017

Issue Overview

For example: if you sort donation listing page by form_id then donation listing page will sort by form_id but donation statuses link still contains URL to the main donation listing page [sort only with status]

e5835c62613bf84aa8acb60aea077c1e

Expected Behavior

Donation status link must obey donation listing page sorting

Current Behavior

Not working, takes to main donation listing page which sorts by status.

Todos

  • Tests
  • Documentation
@DevinWalker

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

@raftaar1191 if you can get this into 2.0 that would be great. Otherwise, 2.0.1

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Nov 27, 2017

Sure @DevinWalker Will fixed this in Give Core Version 2.0

@ravinderk ravinderk self-assigned this Nov 28, 2017

@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 28, 2017

@DevinWalker I made a direct commit to release/2.0. Can you review this?

For ref: e3275cc...876a5a5

@ravinderk ravinderk added the has pr label Nov 28, 2017

@DevinWalker

This comment has been minimized.

Copy link
Member

commented Nov 29, 2017

Looks good @ravinderk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.