Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-tool): Create new "Dry Run" functionality to test importing donation #2419

Closed
mathetos opened this issue Nov 28, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@mathetos
Copy link
Member

commented Nov 28, 2017

Issue Overview

The Importer Test Mode doesn't work in Give 1.8.16

Expected Behavior

When "Test mode" is enabled, it should not import the donations, but show only the summary screen.

Current Behavior

The donations ARE imported.

Steps to Reproduce (for bugs)

  1. Ask me for a sample CSV that I've been working with.

  2. Upload that CSV

  3. Set the options for the import as follows:
    image

  4. Run the import and the donations will be imported

WordPress Environment

``` ### WordPress Environment ###

Home URL: http://giveimporttest.dev
Site URL: http://giveimporttest.dev
WP Version: 4.9
WP Multisite: –
WP Memory Limit: 512 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Inaccessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: 127.0.0.1, SRV: giveimporttest.dev
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache/2.4.12 (Win32) OpenSSL/1.0.1l PHP/5.5.24
PHP Version: 5.5.24 - We recommend a minimum PHP version of 5.6. See: PHP Requirements in Give
PHP Post Max Size: 512 MB
PHP Time Limit: 600
PHP Max Input Vars: 5000
PHP Max Upload Size: 512 MB
cURL Version: 7.40.0, OpenSSL/1.0.1l
SUHOSIN Installed: –
MySQL Version: 5.6.24
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 1.8.16
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://giveimporttest.dev/donation-confirmation/
Failure Page: http://giveimporttest.dev/donation-failed/
Donation History Page: http://giveimporttest.dev/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Admin Email Notifications: Enabled
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Other Active Plugins

Debug Bar: by wordpressdotorg – 0.9
Debug Bar Console: by koopersmith – 0.3
Debug Bar List Script & Style Dependencies: by Per Soderlind – 1.1
Debug Bar Post Meta: by whyisjake – 0.5.4
Give - Hook Helper: by Ravinder Kumar – 1.0
Query Monitor: by John Blackbourn – 2.17.0
Transients Manager: by Pippin Williamson – 1.7.3

Inactive Plugins

Theme

Name: Twenty Sixteen
Version: 1.4
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

</details>

@ravinderk ravinderk added the bug label Nov 28, 2017

@ravinderk ravinderk added this to the 1.8.17 milestone Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

@DevinWalker

This comment has been minimized.

Copy link
Member

commented Nov 28, 2017

It's confusing that it's called "Test mode" then. It should be called something like "Dry run" - let's discuss @raftaar1191 before you continue working on this one.

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 28, 2017

@DevinWalker

This comment has been minimized.

Copy link
Member

commented Nov 28, 2017

@raftaar1191 after discussing with @mathetos here's how to proceed on this issue:

Testing Mode and New "Dry Run" Feature

Step 1

Shift the functionality you developed into a new "Dry Run" feature which allows you to "test" how an import will work to view duplicates and what items will be created before actually importing any data.

Add new "Dry Run" Checkbox

importer-dry-run-checkbox

Notice: I also changed the button text and touched up the styles. Please add this as well to the UI.

Change description of "Test Mode" option

Description should be:

Choose whether you would like the imported donations to be created in test mode or not.

Note: This option should be disabled by default.

Step 2

Add a new "Dry Run" summary page.

When a "Dry Run" is performed the end result should be a summary page like so:

importer-dry-run

  1. No data is created
  2. Report is accurate reflection of live import
  3. Admin can easily run actual import or tweak CSV and try dry run again

@DevinWalker DevinWalker changed the title IMPORTER: Test Mode doesn't work in Give 1.8.16 IMPORTER: Create new "Dry Run" functionality to test importing without importing data Nov 28, 2017

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Nov 28, 2017

For now, I am entering the donations in the DB and once it gets completed I will again delete all the donation entry

Will create another issue that will be refracting the Importer donation Dry run in which no entry will be added to DB

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 29, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 29, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 30, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 30, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 30, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Dec 1, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Dec 1, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Dec 1, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Dec 4, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Dec 4, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Dec 4, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Dec 4, 2017

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Dec 4, 2017

@DevinWalker DevinWalker modified the milestones: 2.0.2, 2.1 Jan 27, 2018

@DevinWalker DevinWalker removed this from the 2.1 milestone Mar 6, 2018

@kevinwhoffman kevinwhoffman added this to the Sprint: 2018/03/28 - 2018/04/10 milestone Mar 28, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 3, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 4, 2018

@raftaar1191 raftaar1191 changed the title IMPORTER: Create new "Dry Run" functionality to test importing without importing data feat(admin-tool): Create new "Dry Run" functionality to test importing without importing data Apr 6, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 6, 2018

@raftaar1191 raftaar1191 changed the title feat(admin-tool): Create new "Dry Run" functionality to test importing without importing data WIP: feat(admin-tool): Create new "Dry Run" functionality to test importing donation Apr 6, 2018

@raftaar1191 raftaar1191 changed the title WIP: feat(admin-tool): Create new "Dry Run" functionality to test importing donation feat(admin-tool): Create new "Dry Run" functionality to test importing donation Apr 6, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 6, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 6, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 9, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 10, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 10, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 10, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 10, 2018

DevinWalker added a commit that referenced this issue Apr 12, 2018

Merge pull request #3001 from raftaar1191/feat-2419
feat(admin-tool): Create new "Dry Run" functionality to test importing donation #2419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.