Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve give_locate_template #2577

Closed
ravinderk opened this issue Dec 25, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@ravinderk
Copy link
Collaborator

commented Dec 25, 2017

Issue Overview

In give_get_template fn we are passing $template_path and $default_path path to give_locate_template fn but it only accept boolean as second and third param.We can improve this fn to handle default path logic.

This will be helpful to Give addon developers if this give_locate_template fn locates and load template on basis of fn arguments.

For ref: https://github.com/WordImpress/Give/blob/f5bc216de9a8fb778014ab2b9e6e8dea22580d9b/includes/template-functions.php#L54

@DevinWalker

This comment has been minimized.

Copy link
Member

commented Dec 26, 2017

@ravinderk which milestone?

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Dec 27, 2017

milestone 2.0

@DevinWalker DevinWalker added this to the 2.0 milestone Dec 27, 2017

@ravinderk ravinderk modified the milestones: 2.0, 2.0.1 Jan 9, 2018

@ravinderk ravinderk modified the milestones: 2.0.1, 2.0.2 Jan 22, 2018

@DevinWalker DevinWalker modified the milestones: 2.0.2, 2.0.3 Jan 27, 2018

@ravinderk ravinderk changed the title Improve give_locate_template refactor: Improve give_locate_template Feb 9, 2018

@ravinderk ravinderk added the has pr label Feb 9, 2018

ravinderk added a commit that referenced this issue Feb 9, 2018

Merge pull request #2794 from ravinderk/issues/2577
refactor(template): add helper give_get_locate_template fn #2577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.