Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom amount label from set donation {donation} tag #2653

Closed
Benunc opened this issue Jan 11, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@Benunc
Copy link
Member

commented Jan 11, 2018

Issue Overview

Related to #2161

The custom amount level should not be appended to a set donation's {donation} tag in emails, or in the Donation Receipt shortcode output.

Expected Behavior

Unless customized, I wouldn't want to display the text on the front end of a site at all (current behavior), and I don't think there should be any reason that it is ever appended to the donation title in a tag, or in the Donation receipt shortcode.

Current Behavior

The custom amount text is appended to the Form title on the {donation} tag, if it has been customized, and just the words "Custom Amount" if it hasn't been customized.
screen shot 2018-01-11 at 5 57 32 pm
(name of the form is "set with Custom Amount")

screen shot 2018-01-11 at 5 57 22 pm
There's no need to put "custom amount" on that table. I don't even think it needs to be put there for customized text.

Possible solution

If it is a set donation form, the {donation} tag always and only gets the Form Title on the {donation} tag, and in the shortcode output.

Steps to Reproduce (for bugs)

  1. Create a set level donation form
  2. Enable custom amounts
  3. Ensure that the {donation} tag is in use on the email receipt
  4. Submit a test donation and check the email.

On both the donation receipt {give_receipt] shortcode, and the email, the form title has either "custom amount" (if it's not custom text added) or the custom message that users can add on the back end of the site.

Related Issues and/or PRs

#2161

Todos

  • Tests
@Benunc

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2018

User following up on this issue.

@DevinWalker DevinWalker added this to the 2.0.3 milestone Jan 30, 2018

@DevinWalker DevinWalker added the UI / UX label Jan 30, 2018

@DevinWalker DevinWalker self-assigned this Jan 30, 2018

@DevinWalker

This comment has been minimized.

Copy link
Member

commented Jan 30, 2018

@Benunc scheduled this one for the next point release

@ravinderk ravinderk added the has pr label Feb 9, 2018

ravinderk added a commit that referenced this issue Feb 9, 2018

Merge pull request #2795 from Sidsector9/issue-2653
fix(payments): Remove custom amount label from set donation {donation} tag #2653

@ravinderk ravinderk closed this Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.