Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency Position dosn't update when you change Currency (you have to save) #2667

Closed
gingerling opened this issue Jan 17, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@gingerling
Copy link

commented Jan 17, 2018

Issue Overview

On General > Currency menu page, if you change the currency from eg. Dollars to Pounds, the currency mentioned in the Currency Position dropdown below does not update until you save the page.

Expected Behavior

You change currency and the currency position dialogue changes to correct currency right away

Current Behavior

It dosn't change

Possible Solution

Steps to Reproduce (for bugs)

  1. Go to On General > Currency menu page
  2. Change the currency from eg. Dollars to Pounds
  3. Check currency in currency position is still $ not £ (Even if you click on the dialogue)
  4. Save page
  5. It is now £ as is correct.

Related Issues and/or PRs

Todos

  • Tests
  • Documentation

WordPress Environment

``` Copy and paste the system Info report from **Donations > Tools > System Info** in WordPress admin here. ```

@ravinderk ravinderk added this to the 2.0.1 milestone Jan 17, 2018

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 18, 2018

ravinderk added a commit that referenced this issue Jan 18, 2018

Merge pull request #2674 from raftaar1191/issues-2667
issues #2667 On currency change the currency place text symbol #2667

DevinWalker added a commit that referenced this issue Jan 19, 2018

Merge branch 'release/2.0.1' into issue/339
* release/2.0.1:
  Add backward compatibility for _give_payment_meta
  Remove error_log
  Change currency position setting attribute names
  Add table prefix by $wpdb->prefix
  On currency change the curreny place text symbol #2667

DevinWalker added a commit that referenced this issue Jan 19, 2018

Merge branch 'issue/339' into feature/gutenberg-donation-form-block
* issue/339:
  Add backward compatibility for _give_payment_meta
  Remove error_log
  Change currency position setting attribute names
  Add table prefix by $wpdb->prefix
  On currency change the curreny place text symbol #2667
  Minor text updates
  Set heading for user registration emails
  Update new user registration email titles
  Update HTMl to add id attribute #2661
  Manually merged changes from PR #2665
  Removed extra space
  added changelog and created new POT file
  Ran gulp
  Added white bg for float labels - not sure why this wasn't done in #2155 but it is now...
  Hide run update button if upgrades running
  Verify meta_id before insert data to new meta tables
  Varify update dependency early then in foreach loop
  Remove opacity from give-disabled class run gulp #2664
  Add class give-disable which return false and add some css  and run gulp #2664
  Fix element id name #2661

# Conflicts:
#	languages/give.pot

DevinWalker added a commit that referenced this issue Jan 19, 2018

Merge branch 'release/2.0.1'
* release/2.0.1:
  Fixing packagist complaining about license value
  Reduce the max limit of posts_per_page for windows OS.
  Remove error_log
  Change currency position setting attribute names
  On currency change the curreny place text symbol #2667

DevinWalker added a commit that referenced this issue Jan 19, 2018

Merge branch 'master' into feature/update-process
* master:
  Apply posts_where clause on payment sql query
  Add __rename_meta_table_name reusable fn
  Use $meta_type to generate table name
  Fix #2683
  Fix broken unit test.
  Added icon and updated text for per form email tab - Fixes #2680
  Resolved issue with untranslatable string and incorrect variable name
  Stop emailing me...
  Fixing packagist complaining about license value
  Reduce the max limit of posts_per_page for windows OS.
  Remove error.log code
  Fix upgrades
  Fix broken update
  Remove error_log
  Change currency position setting attribute names
  On currency change the curreny place text symbol #2667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.