Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause and restart feature to background update #2676

Closed
ravinderk opened this issue Jan 18, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@ravinderk
Copy link
Collaborator

commented Jan 18, 2018

@ravinderk ravinderk self-assigned this Jan 18, 2018

@ravinderk ravinderk added this to the 2.0.1 milestone Jan 18, 2018

@mathetos

This comment has been minimized.

Copy link
Member

commented Jan 18, 2018

I think it's important with this feature that the upgrade routine be smart enough to know where it is in the process of updating when it was paused. Essentially, when paused, and then restarted, it should be able to start up again where it left off, rather than restart from the beginning and potentially over-write new information accidentally.

A couple considerations as well:

  1. If the "pause" button is hit and the user leaves the page, there should be a new admin alert that says "You've paused the Give database update process. We highly recommend continuing that process to completion as soon as possible. Click here to continue now."

  2. What will the "restart" actually do? Will it check for existing data and skip it if it exists? Or simply migrate all data regardless?

  3. Maybe it's most important to detect when the upgrade process gets stuck, and then restart automatically, or provide some sort of error logging for what might potentially have caused the process to get stuck... If it does get stuck, it would be great to give them the option to email us with a quick and easy form with error details.

I'm just thinking of all the way this might fail, and how we can get more actionable information as quickly and easily as possible.

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Jan 18, 2018

@ravinderk

I guess we should also add this to our System Report that the update is completed or not. If not then all the details that are associated with the Updating Process

If stop -> Then Update was stopped in between ( .Some Details related to the Update as well )
If Pause -> Then Update was Pause in between ( .Some Details related to the Update as well )
If Completed -> Successfully Message

@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 20, 2018

@raftaar1191 I added updates log under Tools > Logs > Updates.
Note: it will start working on 2.0 update completed because data is storing into a new table.

@ravinderk

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 20, 2018

@mathetos I added an update health check on update restart event.
It will do following things:

  1. Remove update with uncallable function.
  2. Add missing update dependency if any.
  3. Log update event.

@mathetos Review GitHub branch which I mentioned in issue description.

@ravinderk ravinderk referenced this issue Jan 20, 2018

Closed

Fix stalled upgrade process #2671

0 of 2 tasks complete
@DevinWalker

This comment has been minimized.

Copy link
Member

commented Jan 25, 2018

This was closed as the pause / restart feature is now implemented. It's not recommended to actually use at all unless you are positive there's an issue with the update. If there is an issue with the update please implement your backup and contact us on https://wordpress.org/support/plugin/give

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.