Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for per form emails tab and update tab title #2680

Closed
DevinWalker opened this issue Jan 19, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@DevinWalker
Copy link
Member

commented Jan 19, 2018

Issue Overview

  1. This tab should have this mail icon: https://developer.wordpress.org/resource/dashicons/#email-alt

2018-01-18_23-53-19

  1. The tab should also read:

Email Notifications

@DevinWalker DevinWalker added this to the 2.0.1 milestone Jan 19, 2018

@DevinWalker DevinWalker self-assigned this Jan 19, 2018

DevinWalker added a commit that referenced this issue Jan 19, 2018

@DevinWalker DevinWalker added the UI / UX label Jan 19, 2018

@DevinWalker

This comment has been minimized.

Copy link
Member Author

commented Jan 19, 2018

Resolved: b643600

DevinWalker added a commit that referenced this issue Jan 19, 2018

Merge branch 'master' into feature/update-process
* master:
  Apply posts_where clause on payment sql query
  Add __rename_meta_table_name reusable fn
  Use $meta_type to generate table name
  Fix #2683
  Fix broken unit test.
  Added icon and updated text for per form email tab - Fixes #2680
  Resolved issue with untranslatable string and incorrect variable name
  Stop emailing me...
  Fixing packagist complaining about license value
  Reduce the max limit of posts_per_page for windows OS.
  Remove error.log code
  Fix upgrades
  Fix broken update
  Remove error_log
  Change currency position setting attribute names
  On currency change the curreny place text symbol #2667

DevinWalker added a commit that referenced this issue Jan 22, 2018

Merge branch 'release/2.0.1' into issue/339
* release/2.0.1:
  Add clarity to docs
  Version bumped
  Apply posts_where clause on payment sql query
  Add __rename_meta_table_name reusable fn
  Use $meta_type to generate table name
  Fix #2683
  Fix broken unit test.
  Added icon and updated text for per form email tab - Fixes #2680
  Resolved issue with untranslatable string and incorrect variable name
  Stop emailing me...
  Fixing packagist complaining about license value
  Reduce the max limit of posts_per_page for windows OS.
  Fix #2678
  Remove error.log code
  Fix upgrades
  Fix broken update

DevinWalker added a commit that referenced this issue Jan 22, 2018

Merge branch 'issue/339' into feature/gutenberg-donation-form-block
* issue/339:
  Add clarity to docs
  Version bumped
  Apply posts_where clause on payment sql query
  Add __rename_meta_table_name reusable fn
  Use $meta_type to generate table name
  Fix #2683
  Fix broken unit test.
  Added icon and updated text for per form email tab - Fixes #2680
  Resolved issue with untranslatable string and incorrect variable name
  Packagist license validation
  Removed "Built with Gulp" badge since we're building with webpack now...
  Stop emailing me...
  Fixing packagist complaining about license value
  Reduce the max limit of posts_per_page for windows OS.
  Fix #2678
  Remove error.log code
  Fix upgrades
  Fix broken update

DevinWalker added a commit that referenced this issue Jan 23, 2018

Merge branch 'release/2.0.1' into release/2.1
* release/2.0.1: (47 commits)
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  Add clarity to docs
  Version bumped
  Apply posts_where clause on payment sql query
  Add __rename_meta_table_name reusable fn
  Use $meta_type to generate table name
  Fix #2683
  Fix broken unit test.
  Added icon and updated text for per form email tab - Fixes #2680
  Resolved issue with untranslatable string and incorrect variable name
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.