Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n-string): dashboard date not translatable #2811

Closed
chantalcoolsma opened this issue Feb 14, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@chantalcoolsma
Copy link
Contributor

commented Feb 14, 2018

I am working on the Dutch translation and I noticed that the day of the week in the dashboard widget isn't translatable. It is just shown as the English day of the week:

<p class="give-dashboard-happy-day"><?php printf( /* translators: %s: day of the week */ __( 'Happy %s!', 'give' ), date( 'l', current_time( 'timestamp' ) ) ); ?></p>

includes/admin/dashboard-widgets.php

@DevinWalker

This comment has been minimized.

Copy link
Member

commented Feb 14, 2018

Thanks for reporting, I've fixed this issue in the PR above and it will be released today.

@DevinWalker DevinWalker changed the title String not translatable fix(i18n-string): dashboard date not translatable Feb 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.