Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): improve UX/UI of donation form grid #2943

Closed
3 tasks done
kevinwhoffman opened this issue Mar 22, 2018 · 2 comments
Closed
3 tasks done

feat(grid): improve UX/UI of donation form grid #2943

kevinwhoffman opened this issue Mar 22, 2018 · 2 comments
Assignees

Comments

@kevinwhoffman
Copy link
Contributor

kevinwhoffman commented Mar 22, 2018

User Story

As a developer, I want to display the donation form grid via CSS Grid instead of Flexbox so that my galleries can respond to the available space.

There are also a number of shortcode attributes that should be added so that users have control over their form grids.

Current Behavior

I currently use Flexbox and have to specifically choose the max number of columns rather than allowing the gallery to determine its own best fit. My layout options are also limited as Flexbox excels at one-directional layouts whereas Grid excels at two-directional layouts.

Expected Behavior

I expect to use CSS Grid as it is the future of grid-style layouts on the web and should be introduced early before third-party developers start customizing styles based on another approach.

Possible Solution

Replace the current Flexbox layout with CSS Grid and add a Best Fit default style that lay out grid items according the available space.

Related

Issues

Resources

Tasks

  • Replace Flexbox with CSS Grid for the donation form grid layout.
  • Style according to Best Fit by default.
  • Add fallback styles for browsers that don't support Grid.
@kevinwhoffman kevinwhoffman self-assigned this Mar 22, 2018
@kevinwhoffman kevinwhoffman changed the title feat(form): replace flexbox with grid feat(grid): replace Flexbox with CSS Grid and ITCSS Mar 22, 2018
@kevinwhoffman
Copy link
Contributor Author

kevinwhoffman commented Mar 23, 2018

image

Slack Call Summary

Participants: @DevinWalker, @kevinwhoffman
Topic: Review Donation Form Grid styles and behavior
Result: New Grid styles are in place and the overall direction has been approved. Remaining tasks include:

Kevin's Tasks for this Issue

  • Clarify shortcode attribute names.
  • Add missing attributes defined below.
  • Style pagination.
  • Add shortcode attribute to define number of forms displayed.

Sid's Tasks in New Issue

I'm documenting these here temporarily until I can create a new issue.

  • Generate excerpt from form content if the excerpt field is empty.
  • Load modal forms via AJAX rather than hiding every form on the page.

@kevinwhoffman
Copy link
Contributor Author

kevinwhoffman commented Mar 23, 2018

Slack Call Summary

Participants: @mathetos , @kevinwhoffman
Topic: Review shortcode name and attributes
Result: Matt and Kevin discussed shortcode attributes and decided on [give_form_grid].

@kevinwhoffman kevinwhoffman changed the title feat(grid): replace Flexbox with CSS Grid and ITCSS feat(grid): improve UX/UI of donation form grid Mar 26, 2018
DevinWalker pushed a commit that referenced this issue Mar 26, 2018
feat(grid): improve UX/UI of donation form grid #2943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants