Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-plugins): correct number of plugins for Give filter #2953

Closed
DevinWalker opened this issue Mar 27, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@DevinWalker
Copy link
Member

commented Mar 27, 2018

User Story

As a user, I want be sure that the number of plugins for Give specifically appears accurately so that I know which plugins are only Give-related.

Current Behavior

The number is incorrect next to the filter:

2018-03-27_00-55-17

@raftaar1191

This comment has been minimized.

Copy link
Member

commented Mar 27, 2018

Finding

Here we were not looking for the author name so I add a new condition that will also check for the author name with the Plugin name

So now it will look for two thing on for Plugin Name and the Second one is for Author Name

Notes: Some Give Add-on has Author name as WordImpress, LLC and some have Author name as WordImpress so overcome this I am checking for string position in Author name

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Mar 27, 2018

DevinWalker added a commit that referenced this issue Mar 28, 2018

Merge pull request #2957 from raftaar1191/issues-2953
fix(admin-plugins): Add check for author name #2953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.